Move compositor bindings implementations out of WebKit::, fix style

Move compositor bindings implementations out of WebKit::, fix style

This moves the implementation of compositor binding classes in webkit/compositor_bindings/
out of namespace WebKit and into namespace webkit. This is important since several of
the chromium clang style plugin checks key off of the namespace to avoid WebKit API
and thus weren't running on these classes.

Also makes these files cpplint.py clean.

R=enne@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188720

[jamesr, 2013-03-18 05:12:20]

turns out it's relative easy to hack move_source_files.py to fix up include
guards automatically

[enne (OOO), 2013-03-18 06:14:03]

lgtm, with some style comments

Also, DISALLOW_COPY_AND_ASSIGN where needed if you'd like.  I think we'll
probably need a pass to add that in general anyway.

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
File webkit/compositor_bindings/web_animation_impl.h (right):

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
webkit/compositor_bindings/web_animation_impl.h:39: scoped_ptr<cc::Animation>
cloneToAnimation();
CloneToAnimation

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
File webkit/compositor_bindings/web_float_animation_curve_impl.h (right):

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
webkit/compositor_bindings/web_float_animation_curve_impl.h:41:
scoped_ptr<cc::AnimationCurve> cloneToAnimationCurve() const;
CloneToAnimationCurve

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
File webkit/compositor_bindings/web_layer_impl_fixed_bounds.h (right):

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
webkit/compositor_bindings/web_layer_impl_fixed_bounds.h:37: const gfx::Size&
bounds);
const gfx::Size& => gfx::Size, if you feel like it.

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
File webkit/compositor_bindings/web_nine_patch_layer_impl.h (right):

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
webkit/compositor_bindings/web_nine_patch_layer_impl.h:23: void setBitmap(const
SkBitmap& bitmap, const WebKit::WebRect& aperture);
SetBitmap

[jamesr, 2013-03-18 06:36:16]

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
File webkit/compositor_bindings/web_animation_impl.h (right):

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
webkit/compositor_bindings/web_animation_impl.h:39: scoped_ptr<cc::Animation>
cloneToAnimation();
On 2013/03/18 06:14:03, enne wrote:
> CloneToAnimation

Done.

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
File webkit/compositor_bindings/web_float_animation_curve_impl.h (right):

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
webkit/compositor_bindings/web_float_animation_curve_impl.h:41:
scoped_ptr<cc::AnimationCurve> cloneToAnimationCurve() const;
On 2013/03/18 06:14:03, enne wrote:
> CloneToAnimationCurve

Done.

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
File webkit/compositor_bindings/web_layer_impl_fixed_bounds.h (right):

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
webkit/compositor_bindings/web_layer_impl_fixed_bounds.h:37: const gfx::Size&
bounds);
On 2013/03/18 06:14:03, enne wrote:
> const gfx::Size& => gfx::Size, if you feel like it.

Done.

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
File webkit/compositor_bindings/web_nine_patch_layer_impl.h (right):

https://codereview.chromium.org/12496013/diff/2016/webkit/compositor_bindings...
webkit/compositor_bindings/web_nine_patch_layer_impl.h:23: void setBitmap(const
SkBitmap& bitmap, const WebKit::WebRect& aperture);
On 2013/03/18 06:14:03, enne wrote:
> SetBitmap

WebNinePatchLayerImpl doesn't appear to be used anywhere, so I just deleted this
file and the .cc

[commit-bot: I haz the power, 2013-03-18 06:37:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/12496013/6002

[commit-bot: I haz the power, 2013-03-18 07:12:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/12496013/8002

[commit-bot: I haz the power, 2013-03-18 09:46:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/12496013/22001

[Tom Hudson, 2013-03-18 10:37:15]

> WebNinePatchLayerImpl doesn't appear to be used anywhere, so I just deleted
this
> file and the .cc

Alex, you just added WebNinePatchLayerImpl last fall; is it really already
obsolete? Does somebody have 4-month old private patches depending on it that we
lost track of during CY?

It sounds like we expected it to be obsoleted by "DecorationManager", but
CodeSearch says that isn't in the codebase yet.

[commit-bot: I haz the power, 2013-03-18 12:16:36]

Change committed as 188720

[danakj, 2013-03-18 15:47:44]

On Mon, Mar 18, 2013 at 6:37 AM, <tomhudson@chromium.org> wrote:

>
>  WebNinePatchLayerImpl doesn't appear to be used anywhere, so I just
>> deleted
>>
> this
>
>> file and the .cc
>>
>
> Alex, you just added WebNinePatchLayerImpl last fall; is it really already
> obsolete? Does somebody have 4-month old private patches depending on it
> that we
> lost track of during CY?
>
> It sounds like we expected it to be obsoleted by "DecorationManager", but
> CodeSearch says that isn't in the codebase yet.
>

I would expect that all users of the layer access the cc:: type directly.
WebNinePatchLayerImpl would be for WebKit to create such a layer, which it
seems it does not.


>
>
>
https://codereview.chromium.**org/12496013/<https://codereview.chromium.org/1...
>

[aelias_OOO_until_Jul13, 2013-03-18 16:36:39]

Dana is correct.  At the time NinePatchLayer was landed, there wasn't a way to
access the CC interface directly even from Chromium, but this changed soon
afterward.