Source/platform/graphics/filters/custom/CustomFilterValidatedProgram.cpp - Issue 124943003: Remove 'String::append' from some of the blink source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/filters/custom/CustomFilterValidatedProgram.cpp

Issue 124943003: Remove 'String::append' from some of the blink source. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Incorporated review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/filesystem/DOMFilePath.cpp ('K') | « Source/modules/websockets/WebSocketChannel.cpp ('k') | Source/platform/network/HTTPParsers.cpp » ('j') | Source/platform/network/HTTPParsers.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/filters/custom/CustomFilterValidatedProgram.cpp

diff --git a/Source/platform/graphics/filters/custom/CustomFilterValidatedProgram.cpp b/Source/platform/graphics/filters/custom/CustomFilterValidatedProgram.cpp

old mode 100644

new mode 100755

index 63e384383be80e8541611155a126ce7e32294f9e..1e03309de7a8ebd1fec0e1c1c4b701768f7789af

--- a/Source/platform/graphics/filters/custom/CustomFilterValidatedProgram.cpp

+++ b/Source/platform/graphics/filters/custom/CustomFilterValidatedProgram.cpp

@@ -290,7 +290,7 @@ String CustomFilterValidatedProgram::blendFunctionString(blink::WebBlendMode ble

const char* blendComponentExpression = "Co = 0.0;";

bool needsLuminosityHelperFunctions = false;

bool needsSaturationHelperFunctions = false;

- String blendFunctionString;

+ StringBuilder blendFunctionString;

switch (blendMode) {

case blink::WebBlendModeNormal:

blendColorExpression = "Cs";

@@ -509,7 +509,7 @@ String CustomFilterValidatedProgram::blendFunctionString(blink::WebBlendMode ble

}

), blendComponentExpression, blendColorExpression));

- return blendFunctionString;

+ return blendFunctionString.toString();

}

String CustomFilterValidatedProgram::compositeFunctionString(CompositeOperator compositeOperator)