Source/core/inspector/InspectorDOMAgent.cpp - Issue 124943003: Remove 'String::append' from some of the blink source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 124943003: Remove 'String::append' from some of the blink source. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Incorporated review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/fetch/CSSStyleSheetResource.cpp ('K') | « Source/core/html/canvas/WebGLRenderingContext.cpp ('k') | Source/core/inspector/NetworkResourcesData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/Source/core/inspector/InspectorDOMAgent.cpp b/Source/core/inspector/InspectorDOMAgent.cpp

old mode 100644

new mode 100755

index abb508d61d2b161c00be9a4df40fc35c6bc38a9c..2338123cd238c2a194b9ab377f7e842914cc64a2

--- a/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/Source/core/inspector/InspectorDOMAgent.cpp

@@ -1457,10 +1457,8 @@ PassRefPtr<TypeBuilder::DOM::Node> InspectorDOMAgent::buildObjectForNode(Node* n

case Node::COMMENT_NODE:

case Node::CDATA_SECTION_NODE:

nodeValue = node->nodeValue();

- if (nodeValue.length() > maxTextSize) {

- nodeValue = nodeValue.left(maxTextSize);

- nodeValue.append(ellipsisUChar);

- }

+ if (nodeValue.length() > maxTextSize)

+ nodeValue = nodeValue.left(maxTextSize) + ellipsisUChar;

break;

case Node::ATTRIBUTE_NODE:

localName = node->localName();