Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: Source/core/fetch/CSSStyleSheetResource.cpp

Issue 124943003: Remove 'String::append' from some of the blink source. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Incorporated review comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/markup.cpp ('k') | Source/core/fetch/FontResource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/fetch/CSSStyleSheetResource.cpp
diff --git a/Source/core/fetch/CSSStyleSheetResource.cpp b/Source/core/fetch/CSSStyleSheetResource.cpp
old mode 100644
new mode 100755
index 7952ec5da2ec71af331f574e7073183978add410..49284b62069722a11e51acc6a46e756f959bbfbe
--- a/Source/core/fetch/CSSStyleSheetResource.cpp
+++ b/Source/core/fetch/CSSStyleSheetResource.cpp
@@ -35,6 +35,7 @@
#include "platform/network/HTTPParsers.h"
#include "wtf/CurrentTime.h"
#include "wtf/Vector.h"
+#include "wtf/text/StringBuilder.h"
namespace WebCore {
@@ -88,9 +89,10 @@ const String CSSStyleSheetResource::sheetText(bool enforceMIMEType, bool* hasVal
return m_decodedSheetText;
// Don't cache the decoded text, regenerating is cheap and it can use quite a bit of memory
- String sheetText = m_decoder->decode(m_data->data(), m_data->size());
+ StringBuilder sheetText;
+ sheetText.append(m_decoder->decode(m_data->data(), m_data->size()));
sheetText.append(m_decoder->flush());
gnana 2014/01/08 16:01:42 I m not sure if this change adds value. I will be
abarth-chromium 2014/01/08 16:35:23 This isn't great either... Maybe String sheetTex
gnana 2014/01/09 08:06:44 This looks better. Modified as you suggested. Don
- return sheetText;
+ return sheetText.toString();
}
void CSSStyleSheetResource::checkNotify()
« no previous file with comments | « Source/core/editing/markup.cpp ('k') | Source/core/fetch/FontResource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698