Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: Source/core/fetch/XSLStyleSheetResource.cpp

Issue 124943003: Remove 'String::append' from some of the blink source. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Incorporated review comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org) 3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org) 4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 7
8 This library is free software; you can redistribute it and/or 8 This library is free software; you can redistribute it and/or
9 modify it under the terms of the GNU Library General Public 9 modify it under the terms of the GNU Library General Public
10 License as published by the Free Software Foundation; either 10 License as published by the Free Software Foundation; either
(...skipping 15 matching lines...) Expand all
26 26
27 #include "config.h" 27 #include "config.h"
28 #include "core/fetch/XSLStyleSheetResource.h" 28 #include "core/fetch/XSLStyleSheetResource.h"
29 29
30 #include "RuntimeEnabledFeatures.h" 30 #include "RuntimeEnabledFeatures.h"
31 #include "core/fetch/ResourceClientWalker.h" 31 #include "core/fetch/ResourceClientWalker.h"
32 #include "core/fetch/StyleSheetResourceClient.h" 32 #include "core/fetch/StyleSheetResourceClient.h"
33 #include "core/fetch/TextResourceDecoder.h" 33 #include "core/fetch/TextResourceDecoder.h"
34 #include "platform/SharedBuffer.h" 34 #include "platform/SharedBuffer.h"
35 #include "wtf/Vector.h" 35 #include "wtf/Vector.h"
36 #include "wtf/text/StringBuilder.h"
36 37
37 namespace WebCore { 38 namespace WebCore {
38 39
39 XSLStyleSheetResource::XSLStyleSheetResource(const ResourceRequest& resourceRequ est) 40 XSLStyleSheetResource::XSLStyleSheetResource(const ResourceRequest& resourceRequ est)
40 : StyleSheetResource(resourceRequest, XSLStyleSheet) 41 : StyleSheetResource(resourceRequest, XSLStyleSheet)
41 , m_decoder(TextResourceDecoder::create("text/xsl")) 42 , m_decoder(TextResourceDecoder::create("text/xsl"))
42 { 43 {
43 ASSERT(RuntimeEnabledFeatures::xsltEnabled()); 44 ASSERT(RuntimeEnabledFeatures::xsltEnabled());
44 DEFINE_STATIC_LOCAL(const AtomicString, acceptXSLT, ("text/xml, application/ xml, application/xhtml+xml, text/xsl, application/rss+xml, application/atom+xml" , AtomicString::ConstructFromLiteral)); 45 DEFINE_STATIC_LOCAL(const AtomicString, acceptXSLT, ("text/xml, application/ xml, application/xhtml+xml, text/xsl, application/rss+xml, application/atom+xml" , AtomicString::ConstructFromLiteral));
45 46
(...skipping 15 matching lines...) Expand all
61 m_decoder->setEncoding(chs, TextResourceDecoder::EncodingFromHTTPHeader); 62 m_decoder->setEncoding(chs, TextResourceDecoder::EncodingFromHTTPHeader);
62 } 63 }
63 64
64 String XSLStyleSheetResource::encoding() const 65 String XSLStyleSheetResource::encoding() const
65 { 66 {
66 return m_decoder->encoding().name(); 67 return m_decoder->encoding().name();
67 } 68 }
68 69
69 void XSLStyleSheetResource::checkNotify() 70 void XSLStyleSheetResource::checkNotify()
70 { 71 {
72 StringBuilder sheet;
71 if (m_data.get()) { 73 if (m_data.get()) {
72 m_sheet = m_decoder->decode(m_data->data(), encodedSize()); 74 sheet.append(m_decoder->decode(m_data->data(), encodedSize()));
73 m_sheet.append(m_decoder->flush()); 75 sheet.append(m_decoder->flush());
76 m_sheet = sheet.toString();
74 } 77 }
75 78
76 ResourceClientWalker<StyleSheetResourceClient> w(m_clients); 79 ResourceClientWalker<StyleSheetResourceClient> w(m_clients);
77 while (StyleSheetResourceClient* c = w.next()) 80 while (StyleSheetResourceClient* c = w.next())
78 c->setXSLStyleSheet(m_resourceRequest.url(), m_response.url(), m_sheet); 81 c->setXSLStyleSheet(m_resourceRequest.url(), m_response.url(), m_sheet);
79 } 82 }
80 83
81 } // namespace WebCore 84 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698