Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: Source/core/fetch/FontResource.cpp

Issue 124943003: Remove 'String::append' from some of the blink source. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Incorporated review comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Torch Mobile, Inc. 3 * Copyright (C) 2009 Torch Mobile, Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 } 103 }
104 104
105 #if ENABLE(SVG_FONTS) 105 #if ENABLE(SVG_FONTS)
106 bool FontResource::ensureSVGFontData() 106 bool FontResource::ensureSVGFontData()
107 { 107 {
108 if (!m_externalSVGDocument && !errorOccurred() && !isLoading()) { 108 if (!m_externalSVGDocument && !errorOccurred() && !isLoading()) {
109 if (m_data) { 109 if (m_data) {
110 m_externalSVGDocument = SVGDocument::create(); 110 m_externalSVGDocument = SVGDocument::create();
111 111
112 OwnPtr<TextResourceDecoder> decoder = TextResourceDecoder::create("a pplication/xml"); 112 OwnPtr<TextResourceDecoder> decoder = TextResourceDecoder::create("a pplication/xml");
113 String svgSource = decoder->decode(m_data->data(), m_data->size()); 113 StringBuilder svgSource;
114 svgSource.append(decoder->decode(m_data->data(), m_data->size()));
114 svgSource.append(decoder->flush()); 115 svgSource.append(decoder->flush());
115 116
116 m_externalSVGDocument->setContent(svgSource); 117 m_externalSVGDocument->setContent(svgSource.toString());
117 118
118 if (decoder->sawError()) 119 if (decoder->sawError())
119 m_externalSVGDocument = 0; 120 m_externalSVGDocument = 0;
120 } 121 }
121 if (!m_externalSVGDocument) 122 if (!m_externalSVGDocument)
122 setStatus(DecodeError); 123 setStatus(DecodeError);
123 } 124 }
124 125
125 return m_externalSVGDocument; 126 return m_externalSVGDocument;
126 } 127 }
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 } 163 }
163 164
164 void FontResource::checkNotify() 165 void FontResource::checkNotify()
165 { 166 {
166 ResourceClientWalker<FontResourceClient> w(m_clients); 167 ResourceClientWalker<FontResourceClient> w(m_clients);
167 while (FontResourceClient* c = w.next()) 168 while (FontResourceClient* c = w.next())
168 c->fontLoaded(this); 169 c->fontLoaded(this);
169 } 170 }
170 171
171 } 172 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698