Keyboard shortcut to log views, layers, windows

Keyboard shortcut to log views, layers, windows

Needed to troubleshoot end-user UI lockups on Chrome OS Ash.

BUG=196626
TEST=manual, hit Ctrl-Alt-Shift-U and see more info in the logs
TBR=sky@chromium.org for logging-only changes in ui/*


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188561

[James Cook, 2013-03-16 00:08:57]

sky, PTAL

skuhne, FYI

[Daniel Erat, 2013-03-16 03:32:22]

lgtm

https://codereview.chromium.org/12494011/diff/1/ash/accelerators/accelerator_...
File ash/accelerators/accelerator_controller.cc (right):

https://codereview.chromium.org/12494011/diff/1/ash/accelerators/accelerator_...
ash/accelerators/accelerator_controller.cc:307: << " type=" << window->type()
nit: fix indenting on this and following lines

https://codereview.chromium.org/12494011/diff/1/ui/views/debug_utils.cc
File ui/views/debug_utils.cc (right):

https://codereview.chromium.org/12494011/diff/1/ui/views/debug_utils.cc#newco...
ui/views/debug_utils.cc:50: LOG(WARNING) << buf.str();
any reason why this is WARNING instead of ERROR?

[James Cook, 2013-03-16 04:09:23]

https://codereview.chromium.org/12494011/diff/1/ash/accelerators/accelerator_...
File ash/accelerators/accelerator_controller.cc (right):

https://codereview.chromium.org/12494011/diff/1/ash/accelerators/accelerator_...
ash/accelerators/accelerator_controller.cc:307: << " type=" << window->type()
On 2013/03/16 03:32:23, Daniel Erat wrote:
> nit: fix indenting on this and following lines

Done.

https://codereview.chromium.org/12494011/diff/1/ui/views/debug_utils.cc
File ui/views/debug_utils.cc (right):

https://codereview.chromium.org/12494011/diff/1/ui/views/debug_utils.cc#newco...
ui/views/debug_utils.cc:50: LOG(WARNING) << buf.str();
On 2013/03/16 03:32:23, Daniel Erat wrote:
> any reason why this is WARNING instead of ERROR?

No, good catch.

[commit-bot: I haz the power, 2013-03-16 04:10:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/12494011/7001

[commit-bot: I haz the power, 2013-03-16 09:26:56]

Change committed as 188561