The download arrow is not vertically centered and needs to be shifted down by 2 pt.

The download arrow is not vertically centered and needs to be shifted down by 2 pt.

BUG=173251
TEST=Open any page that downloads an attachment such as gmail email with an attachment or
   a page with an image. Download the image or an attachment - that will open a download bar at the bottom of the window. Verify that the downward arrow in the bar is centered vertically.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190050

[varkha, 2013-03-18 18:08:13]

Changes are to strictly address what was described in the bug description.
Please see additional comments at
https://code.google.com/p/chromium/issues/detail?id=173251

[sky, 2013-03-18 19:28:40]

https://codereview.chromium.org/12490014/diff/1/chrome/browser/ui/views/downl...
File chrome/browser/ui/views/download/download_shelf_view.cc (right):

https://codereview.chromium.org/12490014/diff/1/chrome/browser/ui/views/downl...
chrome/browser/ui/views/download/download_shelf_view.cc:323:
rb.GetImageSkiaNamed(IDR_TAB_CLOSE));
I would rather you create another id that references the same image then do
this.

[varkha, 2013-03-18 19:44:19]

On 2013/03/18 19:28:40, sky wrote:
>
https://codereview.chromium.org/12490014/diff/1/chrome/browser/ui/views/downl...
> File chrome/browser/ui/views/download/download_shelf_view.cc (right):
> 
>
https://codereview.chromium.org/12490014/diff/1/chrome/browser/ui/views/downl...
> chrome/browser/ui/views/download/download_shelf_view.cc:323:
> rb.GetImageSkiaNamed(IDR_TAB_CLOSE));
> I would rather you create another id that references the same image then do
> this.

Thank you. What do you think of
https://code.google.com/p/chromium/issues/detail?id=217094 ? Is it related /
linked?

[varkha, 2013-03-18 21:09:23]

Is this (set 3) what you meant?

[sky, 2013-03-18 22:13:25]

https://codereview.chromium.org/12490014/diff/11001/chrome/app/theme/theme_re...
File chrome/app/theme/theme_resources.grd (right):

https://codereview.chromium.org/12490014/diff/11001/chrome/app/theme/theme_re...
chrome/app/theme/theme_resources.grd:755: <structure type="chrome_scaled_image"
name="IDR_CLOSE_BAR_CMN" file="common/tab_close_normal.png" />
Yes, but CMN means nothing to me, maybe IDR_SHELF_CLOSE_BUTTON ?

[varkha, 2013-03-18 22:20:42]

I agree about CMN. Do we want a family of those in case
https://code.google.com/p/chromium/issues/detail?id=217094 is confirmed to have
merits? A separate one for each of the current uses of IDR_CLOSE_BAR (infobars,
bubbles, etc.). Or do you think those other instances of [x] button deserve to
remain different from the tab close asset?

[sky, 2013-03-19 13:49:24]

You'll have to talk with the designers on that. I'm also OK renaming
IDR_TAB_**CLOSE to something like IDR_COMMON_**CLOSE to indicate it is not
tab specific.

  -Scott


On Mon, Mar 18, 2013 at 3:20 PM, <varkha@chromium.org> wrote:

> I agree about CMN. Do we want a family of those in case
>
https://code.google.com/p/**chromium/issues/detail?id=**217094<https://code.g...
confirmed to have
> merits? A separate one for each of the current uses of IDR_CLOSE_BAR
> (infobars,
> bubbles, etc.). Or do you think those other instances of [x] button
> deserve to
> remain different from the tab close asset?
>
>
https://codereview.chromium.**org/12490014/<https://codereview.chromium.org/1...
>

[varkha, 2013-03-20 18:25:05]

Please review. This change now is restricted to just re-centering the download
arrow in the download shelf. The rest of the issues described and commented on
in BUG=173251 were separated into BUG=217094.

[sky, 2013-03-20 21:14:15]

LGTM

[commit-bot: I haz the power, 2013-03-21 17:27:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/12490014/43004

[commit-bot: I haz the power, 2013-03-22 18:17:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/12490014/43004

[commit-bot: I haz the power, 2013-03-23 14:54:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/12490014/43004

[commit-bot: I haz the power, 2013-03-23 18:24:17]

Change committed as 190050