Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Side by Side Diff: src/optimizing-compiler-thread.h

Issue 12488006: Parallel recompilation: remove interrupt for code generation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-inl.h ('k') | src/optimizing-compiler-thread.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 class OptimizingCompilerThread : public Thread { 43 class OptimizingCompilerThread : public Thread {
44 public: 44 public:
45 explicit OptimizingCompilerThread(Isolate *isolate) : 45 explicit OptimizingCompilerThread(Isolate *isolate) :
46 Thread("OptimizingCompilerThread"), 46 Thread("OptimizingCompilerThread"),
47 #ifdef DEBUG 47 #ifdef DEBUG
48 thread_id_(0), 48 thread_id_(0),
49 #endif 49 #endif
50 isolate_(isolate), 50 isolate_(isolate),
51 stop_semaphore_(OS::CreateSemaphore(0)), 51 stop_semaphore_(OS::CreateSemaphore(0)),
52 input_queue_semaphore_(OS::CreateSemaphore(0)), 52 input_queue_semaphore_(OS::CreateSemaphore(0)),
53 output_queue_semaphore_(OS::CreateSemaphore(0)),
54 time_spent_compiling_(0), 53 time_spent_compiling_(0),
55 time_spent_total_(0) { 54 time_spent_total_(0) {
56 NoBarrier_Store(&stop_thread_, static_cast<AtomicWord>(false)); 55 NoBarrier_Store(&stop_thread_, static_cast<AtomicWord>(false));
57 NoBarrier_Store(&queue_length_, static_cast<AtomicWord>(0)); 56 NoBarrier_Store(&queue_length_, static_cast<AtomicWord>(0));
58 } 57 }
59 58
60 void Run(); 59 void Run();
61 void Stop(); 60 void Stop();
62 void CompileNext(); 61 void CompileNext();
63 void QueueForOptimization(OptimizingCompiler* optimizing_compiler); 62 void QueueForOptimization(OptimizingCompiler* optimizing_compiler);
64 void InstallOptimizedFunctions(); 63 void InstallOptimizedFunctions();
65 64
66 // Wait for the next optimized function and install it.
67 Handle<SharedFunctionInfo> InstallNextOptimizedFunction();
68
69 inline bool IsQueueAvailable() { 65 inline bool IsQueueAvailable() {
70 // We don't need a barrier since we have a data dependency right 66 // We don't need a barrier since we have a data dependency right
71 // after. 67 // after.
72 Atomic32 current_length = NoBarrier_Load(&queue_length_); 68 Atomic32 current_length = NoBarrier_Load(&queue_length_);
73 69
74 // This can be queried only from the execution thread. 70 // This can be queried only from the execution thread.
75 ASSERT(!IsOptimizerThread()); 71 ASSERT(!IsOptimizerThread());
76 // Since only the execution thread increments queue_length_ and 72 // Since only the execution thread increments queue_length_ and
77 // only one thread can run inside an Isolate at one time, a direct 73 // only one thread can run inside an Isolate at one time, a direct
78 // doesn't introduce a race -- queue_length_ may decreased in 74 // doesn't introduce a race -- queue_length_ may decreased in
79 // meantime, but not increased. 75 // meantime, but not increased.
80 return (current_length < FLAG_parallel_recompilation_queue_length); 76 return (current_length < FLAG_parallel_recompilation_queue_length);
81 } 77 }
82 78
83 #ifdef DEBUG 79 #ifdef DEBUG
84 bool IsOptimizerThread(); 80 bool IsOptimizerThread();
85 #endif 81 #endif
86 82
87 ~OptimizingCompilerThread() { 83 ~OptimizingCompilerThread() {
88 delete output_queue_semaphore_; // Only used for manual mode.
89 delete input_queue_semaphore_; 84 delete input_queue_semaphore_;
90 delete stop_semaphore_; 85 delete stop_semaphore_;
91 } 86 }
92 87
93 private: 88 private:
94 #ifdef DEBUG 89 #ifdef DEBUG
95 int thread_id_; 90 int thread_id_;
96 #endif 91 #endif
97 92
98 Isolate* isolate_; 93 Isolate* isolate_;
99 Semaphore* stop_semaphore_; 94 Semaphore* stop_semaphore_;
100 Semaphore* input_queue_semaphore_; 95 Semaphore* input_queue_semaphore_;
101 Semaphore* output_queue_semaphore_; 96 Semaphore* output_queue_semaphore_;
102 UnboundQueue<OptimizingCompiler*> input_queue_; 97 UnboundQueue<OptimizingCompiler*> input_queue_;
103 UnboundQueue<OptimizingCompiler*> output_queue_; 98 UnboundQueue<OptimizingCompiler*> output_queue_;
104 volatile AtomicWord stop_thread_; 99 volatile AtomicWord stop_thread_;
105 volatile Atomic32 queue_length_; 100 volatile Atomic32 queue_length_;
106 int64_t time_spent_compiling_; 101 int64_t time_spent_compiling_;
107 int64_t time_spent_total_; 102 int64_t time_spent_total_;
108 }; 103 };
109 104
110 } } // namespace v8::internal 105 } } // namespace v8::internal
111 106
112 #endif // V8_OPTIMIZING_COMPILER_THREAD_H_ 107 #endif // V8_OPTIMIZING_COMPILER_THREAD_H_
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | src/optimizing-compiler-thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698