base: Move the rest of JSONValueSerializer unit tests from c/common to base/json.

base: Move the rest of JSONValueSerializer unit tests from c/common to base/json.

This is the follow up patch to r189315 - https://codereview.chromium.org/12910004
where we moved the half of tests that didn't depend on json test files.

json_value_serializer_perftest.cc was not moved yet because it depends on
chrome/common/logging_chrome.h

TEST=base_unittests --gtest_filter=*JSON*
TEST=perf_tests --gtest_filter=JSONValueSerializerTests*

R=darin@chromium.org,bulach@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191077

[tfarina, 2013-03-23 18:46:00]

Hi Darin, could you review this to me?

Marcus, please review test_runner.py

Thanks,

https://codereview.chromium.org/12481028/diff/1/build/android/pylib/gtest/tes...
File build/android/pylib/gtest/test_runner.py (right):

https://codereview.chromium.org/12481028/diff/1/build/android/pylib/gtest/tes...
build/android/pylib/gtest/test_runner.py:35: 'base/data/file_util_unittest',
I can unify base/data/file_util_unittest, base/data/file_util_unittest,
base/prefs/test/data/pref_service in a follow up CL if you think it's worth. And
of course if you are fine with this CL.

[tfarina, 2013-03-23 20:15:41]

Avi, could you take a look at this change and may be help me understand why
ios_dbg_simulator is failing?

If not, could suggest someone more familiar with ios?

Thanks,

[tfarina, 2013-03-23 22:39:31]

-avi

base_unittests in ios_dbg_simulator was fixed by patch set 6!

[bulach, 2013-03-25 11:57:27]

hmm, android lgtm, but...there's already "base/data" (which contains
$TEST_SUITE/ subdirectories) and prefs/test/data (that is,
$TEST_SUITE/test/data..).. this would be yet-a-third way :)

any chance of converging all of them?

[tfarina, 2013-03-25 12:54:19]

On Monday, March 25, 2013, wrote:

> hmm, android lgtm, but...there's already "base/data" (which contains
> $TEST_SUITE/ subdirectories) and prefs/test/data (that is,
> $TEST_SUITE/test/data..).. this would be yet-a-third way :)
>
> any chance of converging all of them?

Yep, but I'd rather not do in this change. See my earlier comment on
test_runner.py.

I think it will be easier to unify the directories after this change lands,
because the introduction of DIR_TEST_DATA will simplify the task.


-- 
Thiago

[bulach, 2013-03-25 18:18:01]

lgtm for android, sorry, I missed your comment :)

I agree, so feel free to go ahead once other OWNERS approve..

[tfarina, 2013-03-26 15:33:38]

Darin, friendly ping. I need your OWNERS approval. ;)

Thanks,

[tfarina, 2013-03-27 20:39:52]

Darin, do you have time to look at this? If not, could you let me know, so I can
try asking another base OWNER (brett, will, mark). Not sure who are less busy
though.

Thank you,

[darin (slow to review), 2013-03-27 20:57:26]

LGTM

https://codereview.chromium.org/12481028/diff/3017/base/base_paths.h
File base/base_paths.h (right):

https://codereview.chromium.org/12481028/diff/3017/base/base_paths.h#newcode30
base/base_paths.h:30: DIR_CURRENT,  // current directory
nit: it might be nice to do a re-formatting pass here to make all of the
comments line up in a column again.

[tfarina, 2013-03-27 21:07:59]

https://codereview.chromium.org/12481028/diff/3017/base/base_paths.h
File base/base_paths.h (right):

https://codereview.chromium.org/12481028/diff/3017/base/base_paths.h#newcode30
base/base_paths.h:30: DIR_CURRENT,  // current directory
On 2013/03/27 20:57:26, darin wrote:
> nit: it might be nice to do a re-formatting pass here to make all of the
> comments line up in a column again.

Done.

[commit-bot: I haz the power, 2013-03-27 21:48:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12481028/21001

[commit-bot: I haz the power, 2013-03-27 21:48:23]

Presubmit check for 12481028-21001 failed and returned exit status 1.

INFO:root:Found 10 file(s).

INFO:PRESUBMIT:Skipping pylint: no matching changes.
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/base/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/build/android/PRESUBMIT.py
Running
/b/commit-queue/workdir/chromium/build/android/buildbot/tests/bb_run_bot_test.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit Warnings **
License must match:
.*? Copyright (\(c\) )?(2013|2012|2011|2010|2009|2008|2007|2006|2006-2008) The
Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
governed by a BSD-style license that can be\n.*? found in the LICENSE file\.(?:
\*/)?\n
Found a bad license header in these files:
  base/test/data/serializer_nested_test.js \
  base/test/data/serializer_test.js \
  base/test/data/serializer_test_nowhitespace.js

Presubmit checks took 3.4s to calculate.

[tfarina, 2013-03-27 22:08:58]

Changed the extension from js to json

[commit-bot: I haz the power, 2013-03-27 22:12:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12481028/34001

[commit-bot: I haz the power, 2013-03-28 00:40:06]

Change committed as 191077

[M-A Ruel, 2013-04-04 14:48:06]

https://chromiumcodereview.appspot.com/12481028/diff/34001/base/base_paths.cc
File base/base_paths.cc (right):

https://chromiumcodereview.appspot.com/12481028/diff/34001/base/base_paths.cc...
base/base_paths.cc:30: case DIR_TEST_DATA:
This broke isolated testing. I'll send a follow up patch.