Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 12481022: On Win, the accessible value of a document should be its url. (Closed)

Created:
7 years, 9 months ago by dmazzoni
Modified:
7 years, 9 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

On Win, the accessible value of a document should be its url. This matches Firefox's behavior, may improve screen reader support slightly. BUG=none TBR=dtseng Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190047

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M content/browser/accessibility/accessibility_win_browsertest.cc View 1 chunk +14 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/test/data/accessibility/input-color.html View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 11 (0 generated)
dmazzoni
7 years, 9 months ago (2013-03-20 22:55:39 UTC) #1
aboxhall
lgtm https://codereview.chromium.org/12481022/diff/1/content/test/data/accessibility/input-color.html File content/test/data/accessibility/input-color.html (right): https://codereview.chromium.org/12481022/diff/1/content/test/data/accessibility/input-color.html#newcode5 content/test/data/accessibility/input-color.html:5: @WIN-DENY:value='file://* Why is this necessary here but in ...
7 years, 9 months ago (2013-03-20 23:01:53 UTC) #2
dmazzoni
https://codereview.chromium.org/12481022/diff/1/content/test/data/accessibility/input-color.html File content/test/data/accessibility/input-color.html (right): https://codereview.chromium.org/12481022/diff/1/content/test/data/accessibility/input-color.html#newcode5 content/test/data/accessibility/input-color.html:5: @WIN-DENY:value='file://* On 2013/03/20 23:01:53, aboxhall wrote: > Why is ...
7 years, 9 months ago (2013-03-21 03:48:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/12481022/1
7 years, 9 months ago (2013-03-21 03:53:40 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=125482
7 years, 9 months ago (2013-03-21 07:03:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/12481022/1
7 years, 9 months ago (2013-03-21 07:10:44 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=125534
7 years, 9 months ago (2013-03-21 10:25:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/12481022/1
7 years, 9 months ago (2013-03-21 16:55:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/12481022/1
7 years, 9 months ago (2013-03-22 18:16:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/12481022/1
7 years, 9 months ago (2013-03-23 14:53:30 UTC) #10
commit-bot: I haz the power
7 years, 9 months ago (2013-03-23 17:48:32 UTC) #11
Message was sent while issue was closed.
Change committed as 190047

Powered by Google App Engine
This is Rietveld 408576698