Issue 12481018: ash: Add metrics for screen lock and shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12481018: ash: Add metrics for screen lock and shutdown. (Closed)

Created:
7 years, 9 months ago by Daniel Erat

Modified:
7 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Add metrics for screen lock and shutdown. This adds user action metrics for locking the screen and shutting down via keyboard accelerators or the system tray: Accel_LockScreen_L Accel_LockScreen_LockButton Accel_LockScreen_PowerButton Accel_ShutDown_PowerButton Tray_LockScreen Tray_ShutDown (I'm also throwing in Tray_Help so the help button won't feel lonely.) BUG=181808 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188193

Patch Set 1 #

Patch Set 2 : report metric before requesting lock #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -10 lines)			Patch
M	ash/accelerators/accelerator_controller.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/shell_delegate.h	View		3 chunks	+7 lines, -0 lines	0 comments	Download
M	ash/system/date/tray_date.cc	View		2 chunks	+15 lines, -9 lines	0 comments	Download
M	ash/wm/session_state_controller_impl2.cc	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/ui/ash/chrome_shell_delegate.cc	View		3 chunks	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/12481018/2001

7 years, 9 months ago (2013-03-14 15:00:27 UTC) #3

Message was sent while issue was closed.

Change committed as 188193

Expand Messages | Collapse Messages