Issue 12481012: Implement IBusDaemonControllerDaemonlessImpl.

Issue 12481012: Implement IBusDaemonControllerDaemonlessImpl. (Closed)

Created:
7 years, 9 months ago by Seigo Nonaka

Modified:
7 years, 9 months ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement IBusDaemonControllerDaemonlessImpl. With this patch we can use IME extension API even in Linux Desktop with chromeos=1 configuration. BUG=170671 TEST=try bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187268

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Addressing comments #

Patch Set 4 : Addressing offline comments #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -10 lines)			Patch
	M	chromeos/ime/ibus_daemon_controller.cc	View	1 2 3	2 chunks	+42 lines, -10 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

satorux1

https://codereview.chromium.org/12481012/diff/8001/chromeos/ime/ibus_daemon_controller.cc File chromeos/ime/ibus_daemon_controller.cc (right): https://codereview.chromium.org/12481012/diff/8001/chromeos/ime/ibus_daemon_controller.cc#newcode287 chromeos/ime/ibus_daemon_controller.cc:287: DBusThreadManager::Get()->InitIBusBus("dummy address", The word "dummy" worries me. Please explain ...

7 years, 9 months ago (2013-03-11 01:24:29 UTC) #2

Seigo Nonaka

7 years, 9 months ago (2013-03-11 03:40:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12481012/17001

7 years, 9 months ago (2013-03-11 08:20:11 UTC) #6

Message was sent while issue was closed.

Change committed as 187268

Expand Messages | Collapse Messages