Created a sample extension that shows off event pages, new tab apis, and keyboard shortcuts.

Created a sample extension that shows off event pages, new tab apis, and keyboard shortcuts.

The sample extension, 'Tab Shortcuts', uses the commands api to capture keypresses, and uses the tabs api to toggle the pinned state of the active tab or duplicate the current tab without the need of the tabs permission (using an event page). 

Patch from Aaron Jacobs <samusaaron3@gmail.com>;
BUG=141865
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187728

[cduvall, 2013-03-05 21:36:14]

This is a patch from Aaron Jacobs, adding another sample extension.

[cduvall, 2013-03-05 21:37:54]

cc'ing Aaron.

[Mike West, 2013-03-06 10:15:37]

Thanks for this! One question about permissions, one nit.

https://codereview.chromium.org/12481004/diff/1/chrome/common/extensions/docs...
File chrome/common/extensions/docs/examples/howto/tab_shortcuts/tab_shortcuts.js
(right):

https://codereview.chromium.org/12481004/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/howto/tab_shortcuts/tab_shortcuts.js:12:
chrome.tabs.update({}, function(tab) {
Do you not need 'activeTab' or 'tab' permissions to get the tab's state? I
thought you did.

https://codereview.chromium.org/12481004/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/howto/tab_shortcuts/tab_shortcuts.js:13:
if(command == "toggle-pin-tab")
Nit: Single quotes.

[Aaron Jacobs, 2013-03-07 19:47:25]

https://codereview.chromium.org/12481004/diff/1/chrome/common/extensions/docs...
File chrome/common/extensions/docs/examples/howto/tab_shortcuts/tab_shortcuts.js
(right):

https://codereview.chromium.org/12481004/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/howto/tab_shortcuts/tab_shortcuts.js:12:
chrome.tabs.update({}, function(tab) {
On 2013/03/06 10:15:37, Mike West (chromium) wrote:
> Do you not need 'activeTab' or 'tab' permissions to get the tab's state? I
> thought you did.

Certain fields of the tab's state are not set if the permissions are not used
(e.g. the url of the tab), though the tab itself is still accessible.
See: http://developer.chrome.com/extensions/tabs.html#type-Tab

https://codereview.chromium.org/12481004/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/howto/tab_shortcuts/tab_shortcuts.js:13:
if(command == "toggle-pin-tab")
On 2013/03/06 10:15:37, Mike West (chromium) wrote:
> Nit: Single quotes.

Done.

[Mike West, 2013-03-08 07:06:16]

Thanks, LGTM. You should be able to click the "commit" button now to land this.
Thanks for making this sample!

[commit-bot: I haz the power, 2013-03-12 19:54:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cduvall@chromium.org/12481004/5001

[commit-bot: I haz the power, 2013-03-13 00:59:57]

Change committed as 187728