Add skip_canned option to presubmit_support.

presubmit_support.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
 __version__ = '1.6.1'
 
@@ skipping 1203 matching lines @@
   parser.add_option("--description", default='')
   parser.add_option("--issue", type='int', default=0)
   parser.add_option("--patchset", type='int', default=0)
   parser.add_option("--root", default=os.getcwd(),
                     help="Search for PRESUBMIT.py up to this directory. "
                     "If inherit-review-settings-ok is present in this "
                     "directory, parent directories up to the root file "
                     "system directories will also be searched.")
   parser.add_option("--default_presubmit")
   parser.add_option("--may_prompt", action='store_true', default=False)
+  parser.add_option("--skip_canned", action='append', default=[],
+                    help="A list of checks to skip which appear in "
+                    "presubmit_canned_checks. Can be provided multiple times "
+                    "to skip multiple canned checks.")
   parser.add_option("--rietveld_url", help=optparse.SUPPRESS_HELP)
   parser.add_option("--rietveld_email", help=optparse.SUPPRESS_HELP)
   parser.add_option("--rietveld_password", help=optparse.SUPPRESS_HELP)
   options, args = parser.parse_args(argv)
   if options.verbose >= 2:
     logging.basicConfig(level=logging.DEBUG)
   elif options.verbose:
     logging.basicConfig(level=logging.INFO)
   else:
     logging.basicConfig(level=logging.ERROR)
   change_class, files = load_files(options, args)
   if not change_class:
     parser.error('For unversioned directory, <files> is not optional.')
   logging.info('Found %d file(s).' % len(files))
   rietveld_obj = None
   if options.rietveld_url:
     rietveld_obj = rietveld.CachingRietveld(
         options.rietveld_url,
         options.rietveld_email,
         options.rietveld_password)
+  for method_name in options.skip_canned:

[M-A Ruel, 2013/03/07 15:50:33]

I'd like you to restore them after.

missing = [m for m in options.skip_canned if not
hasattr(presubmit_canned_checks, m)]
if missing:
  parser.error(
      'Attempted to skip nonexistent canned presubmit check: %s' % ',
'.join(missing))

previous = dict((m, getattr(presubmit_canned_checks, m)) for m in
options.skip_canned)

try:
..
except ...:
...
finally:
  for m, l in previous.iteritems():
    setattr(...

+    if hasattr(presubmit_canned_checks, method_name):
+      setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
+    else:
+      parser.error('Attempted to skip nonexistent canned presubmit check: %s'
+                   % method_name)
   try:
     results = DoPresubmitChecks(
         change_class(options.name,
                     options.description,
                     options.root,
                     files,
                     options.issue,
                     options.patchset,
                     options.author),
         options.commit,
         options.verbose,
         sys.stdout,
         sys.stdin,
         options.default_presubmit,
         options.may_prompt,
         rietveld_obj)
     return not results.should_continue()
   except PresubmitFailure, e:
     print >> sys.stderr, e
     print >> sys.stderr, 'Maybe your depot_tools is out of date?'
     print >> sys.stderr, 'If all fails, contact maruel@'
     return 2
 
 
 if __name__ == '__main__':
   fix_encoding.fix_encoding()
   sys.exit(Main(None))