Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 12480009: remove READ_PHONE_STATE permission as AudioManager can achieve the same functionality (Closed)

Created:
7 years, 9 months ago by qinmin
Modified:
7 years, 9 months ago
Reviewers:
Miguel Garcia, Ted C, Yaron
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

remove READ_PHONE_STATE permission as AudioManager can achieve the same functionality AudioManager.AudioFocus_LOSS_TRANSIENT covers the phone ringing case, so we don't need READ_PHONE_STATE permission. PhoneStateListener also impacts the DRT tests as it cannot be created on a background thread BUG=178318 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -34 lines) Patch
M chrome/android/testshell/java/AndroidManifest.xml View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/android/browsertests_apk/AndroidManifest.xml View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/android/shell_apk/AndroidManifest.xml View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaPlayerListener.java View 6 chunks +4 lines, -31 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
qinmin
PTAL
7 years, 9 months ago (2013-03-06 02:22:49 UTC) #1
Ted C
lgtm as far as the androidy bits go. Can't comment on functionality
7 years, 9 months ago (2013-03-06 02:33:50 UTC) #2
Miguel Garcia
lgtm, thanks for fixing.
7 years, 9 months ago (2013-03-06 09:20:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/12480009/1
7 years, 9 months ago (2013-03-06 16:05:45 UTC) #4
commit-bot: I haz the power
Presubmit check for 12480009-1 failed and returned exit status 1. INFO:root:Found 4 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-06 16:05:55 UTC) #5
Yaron
lgtm
7 years, 9 months ago (2013-03-06 18:38:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/12480009/1
7 years, 9 months ago (2013-03-06 18:38:23 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-06 20:48:06 UTC) #8
Message was sent while issue was closed.
Change committed as 186499

Powered by Google App Engine
This is Rietveld 408576698