Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1247903003: Add spellcheck and word suggestion to the prediction service (Closed)

Created:
5 years, 5 months ago by riajiang
Modified:
5 years, 4 months ago
Reviewers:
APW, P.Y., qsr, viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add spellcheck and word suggestion to the prediction service Add suggestion strip to the keyboard service Add default English dictionary Add Android LatinIME/native/jni/src suggestion codebase to third_party/android_prediction Modify keyboard client text display R=anwilson@chromium.org, viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1e6163cf66e4b9491e28733919eb8e413f9fb99b

Patch Set 1 #

Total comments: 70

Patch Set 2 : #

Total comments: 65

Patch Set 3 : fixed prediction service and keyboard suggestion strip #

Patch Set 4 : fixed build problem #

Total comments: 8

Patch Set 5 : #

Patch Set 6 : #

Total comments: 8

Patch Set 7 : #

Total comments: 6

Patch Set 8 : changed third_party/prediction to third_party/android_prediction; added CHROMIUM.diff #

Total comments: 4

Patch Set 9 : format README and CHROMIUM.diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30776 lines, -72 lines) Patch
M .gitignore View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M DEPS View 1 2 3 4 5 6 7 8 1 chunk +11 lines, -0 lines 0 comments Download
M examples/keyboard_client/keyboard_client.cc View 1 2 3 4 5 6 7 8 5 chunks +59 lines, -23 lines 0 comments Download
M mojo/services/prediction/public/interfaces/prediction.mojom View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -8 lines 0 comments Download
M services/keyboard_native/BUILD.gn View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -0 lines 0 comments Download
M services/keyboard_native/key_layout.h View 1 2 3 4 5 6 7 8 6 chunks +12 lines, -0 lines 0 comments Download
M services/keyboard_native/key_layout.cc View 1 2 3 4 5 6 7 8 12 chunks +56 lines, -6 lines 0 comments Download
A services/keyboard_native/predictor.h View 1 2 3 4 5 6 7 8 1 chunk +51 lines, -0 lines 0 comments Download
A services/keyboard_native/predictor.cc View 1 2 3 4 5 6 7 8 1 chunk +129 lines, -0 lines 0 comments Download
A services/keyboard_native/text_update_key.h View 1 2 3 4 5 6 7 8 1 chunk +48 lines, -0 lines 0 comments Download
A services/keyboard_native/text_update_key.cc View 1 2 3 4 5 6 7 8 1 chunk +77 lines, -0 lines 0 comments Download
M services/keyboard_native/view_observer_delegate.h View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -0 lines 0 comments Download
M services/keyboard_native/view_observer_delegate.cc View 1 2 3 4 5 6 7 8 5 chunks +18 lines, -0 lines 0 comments Download
M services/prediction/BUILD.gn View 1 2 3 4 5 6 7 8 2 chunks +19 lines, -0 lines 0 comments Download
A services/prediction/dictionary_service.h View 1 2 3 4 5 6 7 8 1 chunk +51 lines, -0 lines 0 comments Download
A services/prediction/dictionary_service.cc View 1 2 3 4 5 6 7 8 1 chunk +199 lines, -0 lines 0 comments Download
A services/prediction/input_info.h View 1 2 3 4 5 6 7 8 1 chunk +38 lines, -0 lines 0 comments Download
A services/prediction/input_info.cc View 1 2 3 4 5 6 7 8 1 chunk +86 lines, -0 lines 0 comments Download
A services/prediction/key_set.h View 1 2 3 4 5 6 7 8 1 chunk +92 lines, -0 lines 0 comments Download
M services/prediction/prediction_apptests.cc View 1 2 3 4 5 6 7 8 2 chunks +72 lines, -18 lines 0 comments Download
M services/prediction/prediction_service_impl.h View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -3 lines 0 comments Download
M services/prediction/prediction_service_impl.cc View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -13 lines 0 comments Download
A services/prediction/proximity_info_factory.h View 1 2 3 4 5 6 7 8 1 chunk +47 lines, -0 lines 0 comments Download
A services/prediction/proximity_info_factory.cc View 1 2 3 4 5 6 7 8 1 chunk +190 lines, -0 lines 0 comments Download
A services/prediction/res/main_en.dict.sha1 View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A services/prediction/touch_position_correction.h View 1 2 3 4 5 6 7 8 1 chunk +41 lines, -0 lines 0 comments Download
A services/prediction/touch_position_correction.cc View 1 2 3 4 5 6 7 8 1 chunk +72 lines, -0 lines 0 comments Download
A third_party/android_prediction/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +222 lines, -0 lines 0 comments Download
A third_party/android_prediction/CHROMIUM.diff View 1 2 3 4 5 6 7 8 1 chunk +378 lines, -0 lines 0 comments Download
A + third_party/android_prediction/LICENSE View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
A third_party/android_prediction/README.chromium View 1 2 3 4 5 6 7 8 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/android_prediction/defines.h View 1 2 3 4 5 6 7 8 1 chunk +406 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/dic_node.h View 1 2 3 4 5 6 7 8 1 chunk +519 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/dic_node.cpp View 1 2 3 4 5 6 7 8 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/dic_node_pool.h View 1 2 3 4 5 6 7 8 1 chunk +87 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/dic_node_priority_queue.h View 1 2 3 4 5 6 7 8 1 chunk +135 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/dic_node_profiler.h View 1 2 3 4 5 6 7 8 1 chunk +188 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/dic_node_utils.h View 1 2 3 4 5 6 7 8 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/dic_node_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +97 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/dic_node_vector.h View 1 2 3 4 5 6 7 8 1 chunk +88 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/dic_nodes_cache.h View 1 2 3 4 5 6 7 8 1 chunk +190 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/dic_nodes_cache.cpp View 1 2 3 4 5 6 7 8 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/internal/dic_node_properties.h View 1 2 3 4 5 6 7 8 1 chunk +155 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/internal/dic_node_state.h View 1 2 3 4 5 6 7 8 1 chunk +80 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/internal/dic_node_state_input.h View 1 2 3 4 5 6 7 8 1 chunk +94 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/internal/dic_node_state_output.h View 1 2 3 4 5 6 7 8 1 chunk +151 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dicnode/internal/dic_node_state_scoring.h View 1 2 3 4 5 6 7 8 1 chunk +217 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/binary_dictionary_bigrams_iterator.h View 1 2 3 4 5 6 7 8 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/binary_dictionary_shortcut_iterator.h View 1 2 3 4 5 6 7 8 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/bloom_filter.h View 1 2 3 4 5 6 7 8 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/dictionary.h View 1 2 3 4 5 6 7 8 1 chunk +140 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/dictionary.cpp View 1 2 3 4 5 6 7 8 1 chunk +192 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/dictionary_utils.h View 1 2 3 4 5 6 7 8 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/dictionary_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +96 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/digraph_utils.h View 1 2 3 4 5 6 7 8 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/digraph_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +121 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/error_type_utils.h View 1 2 3 4 5 6 7 8 1 chunk +78 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/error_type_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/multi_bigram_map.h View 1 2 3 4 5 6 7 8 1 chunk +86 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/multi_bigram_map.cpp View 1 2 3 4 5 6 7 8 1 chunk +107 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/ngram_listener.h View 1 2 3 4 5 6 7 8 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/property/bigram_property.h View 1 2 3 4 5 6 7 8 1 chunk +66 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/property/unigram_property.h View 1 2 3 4 5 6 7 8 1 chunk +114 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/dictionary/property/word_property.h View 1 2 3 4 5 6 7 8 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/additional_proximity_chars.h View 1 2 3 4 5 6 7 8 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/additional_proximity_chars.cpp View 1 2 3 4 5 6 7 8 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/geometry_utils.h View 1 2 3 4 5 6 7 8 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/normal_distribution.h View 1 2 3 4 5 6 7 8 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/normal_distribution_2d.h View 1 2 3 4 5 6 7 8 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/proximity_info.h View 1 2 3 4 5 6 7 8 1 chunk +128 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/proximity_info.cpp View 1 2 3 4 5 6 7 8 1 chunk +263 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/proximity_info_params.h View 1 2 3 4 5 6 7 8 1 chunk +111 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/proximity_info_params.cpp View 1 2 3 4 5 6 7 8 1 chunk +102 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/proximity_info_state.h View 1 2 3 4 5 6 7 8 1 chunk +233 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/proximity_info_state.cpp View 1 2 3 4 5 6 7 8 1 chunk +306 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/proximity_info_state_utils.h View 1 2 3 4 5 6 7 8 1 chunk +160 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/proximity_info_state_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +1015 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/proximity_info_utils.h View 1 2 3 4 5 6 7 8 1 chunk +236 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/layout/touch_position_correction_utils.h View 1 2 3 4 5 6 7 8 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/policy/dictionary_bigrams_structure_policy.h View 1 2 3 4 5 6 7 8 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/policy/dictionary_header_structure_policy.h View 1 2 3 4 5 6 7 8 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/policy/dictionary_shortcuts_structure_policy.h View 1 2 3 4 5 6 7 8 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/policy/dictionary_structure_with_buffer_policy.h View 1 2 3 4 5 6 7 8 1 chunk +119 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/policy/scoring.h View 1 2 3 4 5 6 7 8 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/policy/suggest_policy.h View 1 2 3 4 5 6 7 8 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/policy/traversal.h View 1 2 3 4 5 6 7 8 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/policy/weighting.h View 1 2 3 4 5 6 7 8 1 chunk +110 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/policy/weighting.cpp View 1 2 3 4 5 6 7 8 1 chunk +202 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/result/suggested_word.h View 1 2 3 4 5 6 7 8 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/result/suggestion_results.h View 1 2 3 4 5 6 7 8 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/result/suggestion_results.cpp View 1 2 3 4 5 6 7 8 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/result/suggestions_output_utils.h View 1 2 3 4 5 6 7 8 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/result/suggestions_output_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +229 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/session/dic_traverse_session.h View 1 2 3 4 5 6 7 8 1 chunk +187 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/session/dic_traverse_session.cpp View 1 2 3 4 5 6 7 8 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/session/prev_words_info.h View 1 2 3 4 5 6 7 8 1 chunk +162 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/suggest.h View 1 2 3 4 5 6 7 8 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/suggest.cpp View 1 2 3 4 5 6 7 8 1 chunk +435 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/suggest_interface.h View 1 2 3 4 5 6 7 8 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/core/suggest_options.h View 1 2 3 4 5 6 7 8 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/header/header_policy.h View 1 2 3 4 5 6 7 8 1 chunk +307 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/header/header_policy.cpp View 1 2 3 4 5 6 7 8 1 chunk +160 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/header/header_read_write_utils.h View 1 2 3 4 5 6 7 8 1 chunk +118 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/header/header_read_write_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +231 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/Readme.txt View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/bigram/ver4_bigram_list_policy.h View 1 2 3 4 5 6 7 8 1 chunk +94 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/bigram/ver4_bigram_list_policy.cpp View 1 2 3 4 5 6 7 8 1 chunk +290 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/content/bigram_dict_content.h View 1 2 3 4 5 6 7 8 1 chunk +135 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/content/bigram_dict_content.cpp View 1 2 3 4 5 6 7 8 1 chunk +224 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/content/bigram_entry.h View 1 2 3 4 5 6 7 8 1 chunk +110 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/content/dict_content.h View 1 2 3 4 5 6 7 8 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/content/probability_dict_content.h View 1 2 3 4 5 6 7 8 1 chunk +74 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/content/probability_dict_content.cpp View 1 2 3 4 5 6 7 8 1 chunk +171 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/content/probability_entry.h View 1 2 3 4 5 6 7 8 1 chunk +90 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/content/shortcut_dict_content.h View 1 2 3 4 5 6 7 8 1 chunk +101 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/content/shortcut_dict_content.cpp View 1 2 3 4 5 6 7 8 1 chunk +199 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/content/single_dict_content.h View 1 2 3 4 5 6 7 8 1 chunk +88 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/content/sparse_table_dict_content.h View 1 2 3 4 5 6 7 8 1 chunk +124 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/content/sparse_table_dict_content.cpp View 1 2 3 4 5 6 7 8 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/content/terminal_position_lookup_table.h View 1 2 3 4 5 6 7 8 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/content/terminal_position_lookup_table.cpp View 1 2 3 4 5 6 7 8 1 chunk +111 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/shortcut/ver4_shortcut_list_policy.h View 1 2 3 4 5 6 7 8 1 chunk +118 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_dict_buffers.h View 1 2 3 4 5 6 7 8 1 chunk +152 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_dict_buffers.cpp View 1 2 3 4 5 6 7 8 1 chunk +157 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_dict_constants.h View 1 2 3 4 5 6 7 8 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_dict_constants.cpp View 1 2 3 4 5 6 7 8 1 chunk +81 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_patricia_trie_node_reader.h View 1 2 3 4 5 6 7 8 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_patricia_trie_node_reader.cpp View 1 2 3 4 5 6 7 8 1 chunk +109 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_patricia_trie_node_writer.h View 1 2 3 4 5 6 7 8 1 chunk +145 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_patricia_trie_node_writer.cpp View 1 2 3 4 5 6 7 8 1 chunk +430 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_patricia_trie_policy.h View 1 2 3 4 5 6 7 8 1 chunk +173 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_patricia_trie_policy.cpp View 1 2 3 4 5 6 7 8 1 chunk +541 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_patricia_trie_reading_utils.h View 1 2 3 4 5 6 7 8 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_patricia_trie_reading_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_patricia_trie_writing_helper.h View 1 2 3 4 5 6 7 8 1 chunk +140 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_patricia_trie_writing_helper.cpp View 1 2 3 4 5 6 7 8 1 chunk +304 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_pt_node_array_reader.h View 1 2 3 4 5 6 7 8 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/backward/v402/ver4_pt_node_array_reader.cpp View 1 2 3 4 5 6 7 8 1 chunk +90 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/dictionary_structure_with_buffer_policy_factory.h View 1 2 3 4 5 6 7 8 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/dictionary_structure_with_buffer_policy_factory.cpp View 1 2 3 4 5 6 7 8 1 chunk +205 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/bigram/bigram_list_read_write_utils.h View 1 2 3 4 5 6 7 8 1 chunk +68 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/bigram/bigram_list_read_write_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +96 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/dynamic_pt_gc_event_listeners.h View 1 2 3 4 5 6 7 8 1 chunk +172 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/dynamic_pt_gc_event_listeners.cpp View 1 2 3 4 5 6 7 8 1 chunk +144 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/dynamic_pt_reading_helper.h View 1 2 3 4 5 6 7 8 1 chunk +283 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/dynamic_pt_reading_helper.cpp View 1 2 3 4 5 6 7 8 1 chunk +326 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/dynamic_pt_reading_utils.h View 1 2 3 4 5 6 7 8 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/dynamic_pt_reading_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +72 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/dynamic_pt_updating_helper.h View 1 2 3 4 5 6 7 8 1 chunk +95 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/dynamic_pt_updating_helper.cpp View 1 2 3 4 5 6 7 8 1 chunk +307 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/dynamic_pt_writing_utils.h View 1 2 3 4 5 6 7 8 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/dynamic_pt_writing_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +132 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/patricia_trie_reading_utils.h View 1 2 3 4 5 6 7 8 1 chunk +130 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/patricia_trie_reading_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +163 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/pt_node_array_reader.h View 1 2 3 4 5 6 7 8 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/pt_node_params.h View 1 2 3 4 5 6 7 8 1 chunk +255 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/pt_node_reader.h View 1 2 3 4 5 6 7 8 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/pt_node_writer.h View 1 2 3 4 5 6 7 8 1 chunk +97 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/shortcut/shortcut_list_reading_utils.h View 1 2 3 4 5 6 7 8 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/pt_common/shortcut/shortcut_list_reading_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v2/bigram/bigram_list_policy.h View 1 2 3 4 5 6 7 8 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v2/patricia_trie_policy.h View 1 2 3 4 5 6 7 8 1 chunk +167 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v2/patricia_trie_policy.cpp View 1 2 3 4 5 6 7 8 1 chunk +470 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v2/shortcut/shortcut_list_policy.h View 1 2 3 4 5 6 7 8 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v2/ver2_patricia_trie_node_reader.h View 1 2 3 4 5 6 7 8 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v2/ver2_patricia_trie_node_reader.cpp View 1 2 3 4 5 6 7 8 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v2/ver2_pt_node_array_reader.h View 1 2 3 4 5 6 7 8 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v2/ver2_pt_node_array_reader.cpp View 1 2 3 4 5 6 7 8 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/bigram/ver4_bigram_list_policy.h View 1 2 3 4 5 6 7 8 1 chunk +72 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/bigram/ver4_bigram_list_policy.cpp View 1 2 3 4 5 6 7 8 1 chunk +282 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/content/bigram_dict_content.h View 1 2 3 4 5 6 7 8 1 chunk +128 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/content/bigram_dict_content.cpp View 1 2 3 4 5 6 7 8 1 chunk +219 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/content/bigram_entry.h View 1 2 3 4 5 6 7 8 1 chunk +99 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/content/language_model_dict_content.h View 1 2 3 4 5 6 7 8 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/content/language_model_dict_content.cpp View 1 2 3 4 5 6 7 8 1 chunk +95 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/content/probability_entry.h View 1 2 3 4 5 6 7 8 1 chunk +131 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/content/shortcut_dict_content.h View 1 2 3 4 5 6 7 8 1 chunk +92 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/content/shortcut_dict_content.cpp View 1 2 3 4 5 6 7 8 1 chunk +182 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/content/single_dict_content.h View 1 2 3 4 5 6 7 8 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/content/sparse_table_dict_content.h View 1 2 3 4 5 6 7 8 1 chunk +98 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/content/sparse_table_dict_content.cpp View 1 2 3 4 5 6 7 8 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/content/terminal_position_lookup_table.h View 1 2 3 4 5 6 7 8 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/content/terminal_position_lookup_table.cpp View 1 2 3 4 5 6 7 8 1 chunk +99 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/shortcut/ver4_shortcut_list_policy.h View 1 2 3 4 5 6 7 8 1 chunk +106 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_dict_buffers.h View 1 2 3 4 5 6 7 8 1 chunk +144 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_dict_buffers.cpp View 1 2 3 4 5 6 7 8 1 chunk +214 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_dict_constants.h View 1 2 3 4 5 6 7 8 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_dict_constants.cpp View 1 2 3 4 5 6 7 8 1 chunk +80 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_patricia_trie_node_reader.h View 1 2 3 4 5 6 7 8 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_patricia_trie_node_reader.cpp View 1 2 3 4 5 6 7 8 1 chunk +99 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_patricia_trie_node_writer.h View 1 2 3 4 5 6 7 8 1 chunk +121 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_patricia_trie_node_writer.cpp View 1 2 3 4 5 6 7 8 1 chunk +387 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_patricia_trie_policy.h View 1 2 3 4 5 6 7 8 1 chunk +150 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_patricia_trie_policy.cpp View 1 2 3 4 5 6 7 8 1 chunk +551 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_patricia_trie_reading_utils.h View 1 2 3 4 5 6 7 8 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_patricia_trie_reading_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_patricia_trie_writing_helper.h View 1 2 3 4 5 6 7 8 1 chunk +125 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_patricia_trie_writing_helper.cpp View 1 2 3 4 5 6 7 8 1 chunk +294 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_pt_node_array_reader.h View 1 2 3 4 5 6 7 8 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/structure/v4/ver4_pt_node_array_reader.cpp View 1 2 3 4 5 6 7 8 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/buffer_with_extendable_buffer.h View 1 2 3 4 5 6 7 8 1 chunk +125 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/buffer_with_extendable_buffer.cpp View 1 2 3 4 5 6 7 8 1 chunk +168 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/byte_array_utils.h View 1 2 3 4 5 6 7 8 1 chunk +279 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/byte_array_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/dict_file_writing_utils.h View 1 2 3 4 5 6 7 8 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/dict_file_writing_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +144 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/file_utils.h View 1 2 3 4 5 6 7 8 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/file_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +171 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/forgetting_curve_utils.h View 1 2 3 4 5 6 7 8 1 chunk +113 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/forgetting_curve_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +239 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/format_utils.h View 1 2 3 4 5 6 7 8 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/format_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/historical_info.h View 1 2 3 4 5 6 7 8 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/mmapped_buffer.h View 1 2 3 4 5 6 7 8 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/mmapped_buffer.cpp View 1 2 3 4 5 6 7 8 1 chunk +98 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/probability_utils.h View 1 2 3 4 5 6 7 8 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/sparse_table.h View 1 2 3 4 5 6 7 8 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/sparse_table.cpp View 1 2 3 4 5 6 7 8 1 chunk +101 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/trie_map.h View 1 2 3 4 5 6 7 8 1 chunk +384 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/dictionary/utils/trie_map.cpp View 1 2 3 4 5 6 7 8 1 chunk +387 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/gesture/gesture_suggest_policy_factory.h View 1 2 3 4 5 6 7 8 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/gesture/gesture_suggest_policy_factory.cpp View 1 2 3 4 5 6 7 8 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/typing/scoring_params.h View 1 2 3 4 5 6 7 8 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/typing/scoring_params.cpp View 1 2 3 4 5 6 7 8 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/typing/typing_scoring.h View 1 2 3 4 5 6 7 8 1 chunk +90 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/typing/typing_scoring.cpp View 1 2 3 4 5 6 7 8 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/typing/typing_suggest_policy.h View 1 2 3 4 5 6 7 8 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/typing/typing_suggest_policy.cpp View 1 2 3 4 5 6 7 8 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/typing/typing_suggest_policy_factory.h View 1 2 3 4 5 6 7 8 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/typing/typing_traversal.h View 1 2 3 4 5 6 7 8 1 chunk +186 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/typing/typing_traversal.cpp View 1 2 3 4 5 6 7 8 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/typing/typing_weighting.h View 1 2 3 4 5 6 7 8 1 chunk +221 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/typing/typing_weighting.cpp View 1 2 3 4 5 6 7 8 1 chunk +86 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/utils/damerau_levenshtein_edit_distance_policy.h View 1 2 3 4 5 6 7 8 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/utils/edit_distance.h View 1 2 3 4 5 6 7 8 1 chunk +92 lines, -0 lines 0 comments Download
A third_party/android_prediction/suggest/policyimpl/utils/edit_distance_policy.h View 1 2 3 4 5 6 7 8 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/android_prediction/utils/autocorrection_threshold_utils.h View 1 2 3 4 5 6 7 8 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/android_prediction/utils/autocorrection_threshold_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +109 lines, -0 lines 0 comments Download
A third_party/android_prediction/utils/byte_array_view.h View 1 2 3 4 5 6 7 8 1 chunk +87 lines, -0 lines 0 comments Download
A third_party/android_prediction/utils/char_utils.h View 1 2 3 4 5 6 7 8 1 chunk +130 lines, -0 lines 0 comments Download
A third_party/android_prediction/utils/char_utils.cpp View 1 2 3 4 5 6 7 8 1 chunk +1282 lines, -0 lines 0 comments Download
A third_party/android_prediction/utils/int_array_view.h View 1 2 3 4 5 6 7 8 1 chunk +105 lines, -0 lines 0 comments Download
A third_party/android_prediction/utils/time_keeper.h View 1 2 3 4 5 6 7 8 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/android_prediction/utils/time_keeper.cpp View 1 2 3 4 5 6 7 8 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (3 generated)
riajiang
5 years, 5 months ago (2015-07-23 01:34:04 UTC) #2
APW
Some coding style issues to fix. https://codereview.chromium.org/1247903003/diff/1/mojo/services/prediction/public/interfaces/prediction.mojom File mojo/services/prediction/public/interfaces/prediction.mojom (right): https://codereview.chromium.org/1247903003/diff/1/mojo/services/prediction/public/interfaces/prediction.mojom#newcode9 mojo/services/prediction/public/interfaces/prediction.mojom:9: array<bool> are_beginning_of_sentence; You ...
5 years, 5 months ago (2015-07-23 18:02:15 UTC) #3
qsr
https://codereview.chromium.org/1247903003/diff/1/services/prediction/dictionary_service.cc File services/prediction/dictionary_service.cc (right): https://codereview.chromium.org/1247903003/diff/1/services/prediction/dictionary_service.cc#newcode35 services/prediction/dictionary_service.cc:35: delete default_dictionary; You want to use a std::unique_ptr instead ...
5 years, 5 months ago (2015-07-23 19:40:42 UTC) #5
APW
DictionaryService comments. https://codereview.chromium.org/1247903003/diff/1/services/prediction/dictionary_service.cc File services/prediction/dictionary_service.cc (right): https://codereview.chromium.org/1247903003/diff/1/services/prediction/dictionary_service.cc#newcode38 services/prediction/dictionary_service.cc:38: void DictionaryService::LoadDictionary() { This function name is ...
5 years, 5 months ago (2015-07-23 19:51:39 UTC) #6
APW
https://codereview.chromium.org/1247903003/diff/1/services/prediction/input_info.cc File services/prediction/input_info.cc (right): https://codereview.chromium.org/1247903003/diff/1/services/prediction/input_info.cc#newcode49 services/prediction/input_info.cc:49: void InputInfo::ProcessInput(mojo::String& input) { You should check that input ...
5 years, 5 months ago (2015-07-23 20:11:28 UTC) #7
APW
You'll need a LICENSE, OWNERS, and README.chromium file for the thirdparty code.
5 years, 5 months ago (2015-07-23 20:13:22 UTC) #8
riajiang
https://codereview.chromium.org/1247903003/diff/1/mojo/services/prediction/public/interfaces/prediction.mojom File mojo/services/prediction/public/interfaces/prediction.mojom (right): https://codereview.chromium.org/1247903003/diff/1/mojo/services/prediction/public/interfaces/prediction.mojom#newcode9 mojo/services/prediction/public/interfaces/prediction.mojom:9: array<bool> are_beginning_of_sentence; On 2015/07/23 18:02:15, APW wrote: > You ...
5 years, 4 months ago (2015-07-31 02:13:05 UTC) #9
APW
https://codereview.chromium.org/1247903003/diff/1/mojo/services/prediction/public/interfaces/prediction.mojom File mojo/services/prediction/public/interfaces/prediction.mojom (right): https://codereview.chromium.org/1247903003/diff/1/mojo/services/prediction/public/interfaces/prediction.mojom#newcode9 mojo/services/prediction/public/interfaces/prediction.mojom:9: array<bool> are_beginning_of_sentence; On 2015/07/31 02:13:04, riajiang wrote: > On ...
5 years, 4 months ago (2015-07-31 21:49:16 UTC) #10
APW
5 years, 4 months ago (2015-07-31 21:49:18 UTC) #11
APW
https://codereview.chromium.org/1247903003/diff/10001/examples/keyboard_client/keyboard_client.cc File examples/keyboard_client/keyboard_client.cc (right): https://codereview.chromium.org/1247903003/diff/10001/examples/keyboard_client/keyboard_client.cc#newcode318 examples/keyboard_client/keyboard_client.cc:318: reverse_text[i] = text_[text_.length() - i - 1]; use either ...
5 years, 4 months ago (2015-07-31 22:36:43 UTC) #12
riajiang
https://codereview.chromium.org/1247903003/diff/10001/examples/keyboard_client/keyboard_client.cc File examples/keyboard_client/keyboard_client.cc (right): https://codereview.chromium.org/1247903003/diff/10001/examples/keyboard_client/keyboard_client.cc#newcode318 examples/keyboard_client/keyboard_client.cc:318: reverse_text[i] = text_[text_.length() - i - 1]; On 2015/07/31 ...
5 years, 4 months ago (2015-08-01 01:23:09 UTC) #13
APW
https://codereview.chromium.org/1247903003/diff/10001/services/prediction/dictionary_service.cc File services/prediction/dictionary_service.cc (right): https://codereview.chromium.org/1247903003/diff/10001/services/prediction/dictionary_service.cc#newcode147 services/prediction/dictionary_service.cc:147: if (isupper(cur_beginning)) On 2015/08/01 01:23:09, riajiang wrote: > On ...
5 years, 4 months ago (2015-08-03 17:26:21 UTC) #14
riajiang
https://codereview.chromium.org/1247903003/diff/30001/services/keyboard_native/predictor.cc File services/keyboard_native/predictor.cc (right): https://codereview.chromium.org/1247903003/diff/30001/services/keyboard_native/predictor.cc#newcode32 services/keyboard_native/predictor.cc:32: if (old_size != 0) { On 2015/08/03 17:26:21, APW ...
5 years, 4 months ago (2015-08-03 19:39:43 UTC) #15
APW
https://codereview.chromium.org/1247903003/diff/50001/services/keyboard_native/predictor.cc File services/keyboard_native/predictor.cc (right): https://codereview.chromium.org/1247903003/diff/50001/services/keyboard_native/predictor.cc#newcode43 services/keyboard_native/predictor.cc:43: for (size_t del_count = 0; del_count < old_size - ...
5 years, 4 months ago (2015-08-03 21:38:57 UTC) #16
riajiang
https://codereview.chromium.org/1247903003/diff/50001/services/keyboard_native/predictor.cc File services/keyboard_native/predictor.cc (right): https://codereview.chromium.org/1247903003/diff/50001/services/keyboard_native/predictor.cc#newcode43 services/keyboard_native/predictor.cc:43: for (size_t del_count = 0; del_count < old_size - ...
5 years, 4 months ago (2015-08-03 22:25:05 UTC) #17
viettrungluu
https://codereview.chromium.org/1247903003/diff/60001/third_party/prediction/README.chromium File third_party/prediction/README.chromium (right): https://codereview.chromium.org/1247903003/diff/60001/third_party/prediction/README.chromium#newcode1 third_party/prediction/README.chromium:1: Name: prediction "prediction" is kind of an unfortunately vague ...
5 years, 4 months ago (2015-08-04 16:53:21 UTC) #18
riajiang
https://codereview.chromium.org/1247903003/diff/60001/third_party/prediction/README.chromium File third_party/prediction/README.chromium (right): https://codereview.chromium.org/1247903003/diff/60001/third_party/prediction/README.chromium#newcode1 third_party/prediction/README.chromium:1: Name: prediction On 2015/08/04 16:53:21, viettrungluu wrote: > "prediction" ...
5 years, 4 months ago (2015-08-04 22:16:41 UTC) #20
viettrungluu
third_party LGTM w/nits (but wait for Andrew's LG) https://codereview.chromium.org/1247903003/diff/80001/third_party/android_prediction/CHROMIUM.diff File third_party/android_prediction/CHROMIUM.diff (right): https://codereview.chromium.org/1247903003/diff/80001/third_party/android_prediction/CHROMIUM.diff#newcode3 third_party/android_prediction/CHROMIUM.diff:3: diff ...
5 years, 4 months ago (2015-08-06 00:09:41 UTC) #21
riajiang
https://codereview.chromium.org/1247903003/diff/80001/third_party/android_prediction/CHROMIUM.diff File third_party/android_prediction/CHROMIUM.diff (right): https://codereview.chromium.org/1247903003/diff/80001/third_party/android_prediction/CHROMIUM.diff#newcode3 third_party/android_prediction/CHROMIUM.diff:3: diff -r third_party/android_prediction/defines.h /usr/local/google/home/riajiang/Downloads/android_prediction/defines.h On 2015/08/06 00:09:40, viettrungluu wrote: ...
5 years, 4 months ago (2015-08-06 17:19:43 UTC) #22
APW
lgtm lgtm
5 years, 4 months ago (2015-08-06 18:17:36 UTC) #23
APW
lgtm
5 years, 4 months ago (2015-08-06 18:17:41 UTC) #24
riajiang
5 years, 4 months ago (2015-08-06 20:07:59 UTC) #25
Message was sent while issue was closed.
Committed patchset #9 (id:90001) manually as
1e6163cf66e4b9491e28733919eb8e413f9fb99b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698