Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 12479005: Show strings in content settings bubble when access to cookies is allowed. (Closed)

Created:
7 years, 9 months ago by Bernhard Bauer
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Show strings in content settings bubble when access to cookies is allowed. BUG=181172 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 2 chunks +16 lines, -7 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc View 1 chunk +24 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bernhard Bauer
Please review. Thanks!
7 years, 9 months ago (2013-03-13 01:09:53 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 9 months ago (2013-03-13 09:23:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/12479005/1
7 years, 9 months ago (2013-03-14 11:23:42 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-14 19:53:21 UTC) #4
Message was sent while issue was closed.
Change committed as 188160

Powered by Google App Engine
This is Rietveld 408576698