Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: chrome/browser/ui/sync/one_click_signin_helper.h

Issue 12477009: With browser instant extended enabled, signing in should redirect to chrome://apps instead of to NT… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments (Reverted to patchset 1) Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_ 5 #ifndef CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_
6 #define CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_ 6 #define CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 // when the sign process is over and to collect infomation from the user 169 // when the sign process is over and to collect infomation from the user
170 // entered on the Gaia sign in page (for explicit sign ins). 170 // entered on the Gaia sign in page (for explicit sign ins).
171 static void ShowInfoBarUIThread(const std::string& session_index, 171 static void ShowInfoBarUIThread(const std::string& session_index,
172 const std::string& email, 172 const std::string& email,
173 AutoAccept auto_accept, 173 AutoAccept auto_accept,
174 SyncPromoUI::Source source, 174 SyncPromoUI::Source source,
175 const GURL& continue_url, 175 const GURL& continue_url,
176 int child_id, 176 int child_id,
177 int route_id); 177 int route_id);
178 178
179 void RedirectToNTP(bool show_bubble); 179 void RedirectToNtpOrAppsPage(bool show_bubble);
180 void RedirectToSignin(); 180 void RedirectToSignin();
181 void RedirectOnSigninComplete();
181 182
182 // Clear all data member of the helper, except for the error. 183 // Clear all data member of the helper, except for the error.
183 void CleanTransientState(); 184 void CleanTransientState();
184 185
185 // Grab Gaia password if available. 186 // Grab Gaia password if available.
186 bool OnFormSubmitted(const content::PasswordForm& form); 187 bool OnFormSubmitted(const content::PasswordForm& form);
187 188
188 // content::WebContentsObserver overrides. 189 // content::WebContentsObserver overrides.
189 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; 190 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
190 virtual void DidStopLoading( 191 virtual void DidStopLoading(
(...skipping 24 matching lines...) Expand all
215 GURL continue_url_; 216 GURL continue_url_;
216 // Redirect URL after sync setup is complete. 217 // Redirect URL after sync setup is complete.
217 GURL redirect_url_; 218 GURL redirect_url_;
218 std::string error_message_; 219 std::string error_message_;
219 scoped_ptr<SigninTracker> signin_tracker_; 220 scoped_ptr<SigninTracker> signin_tracker_;
220 221
221 DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelper); 222 DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelper);
222 }; 223 };
223 224
224 #endif // CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_ 225 #endif // CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698