Issue 12477008: Enable EV for AC Camerfirma SA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12477008: Enable EV for AC Camerfirma SA (Closed)

Created:
7 years, 9 months ago by Ryan Sleevi

Modified:
7 years, 9 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable EV for AC Camerfirma SA BUG=73399 TEST=Visit https://www.camerfirma.com and https://server2.camerfirma.com:8082 and see EV badge Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190044

Patch Set 1 #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	net/base/ev_root_ca_metadata.cc	View		1 chunk	+18 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

wtc: Care to rubberstamp? The CA spreadsheet has all the further details.

7 years, 9 months ago (2013-03-21 01:32:33 UTC) #1

wtc

LGTM. https://codereview.chromium.org/12477008/diff/1/net/base/ev_root_ca_metadata.cc File net/base/ev_root_ca_metadata.cc (right): https://codereview.chromium.org/12477008/diff/1/net/base/ev_root_ca_metadata.cc#newcode44 net/base/ev_root_ca_metadata.cc:44: // https://www.camerfirma.com While inspecting the cert chain of ...

7 years, 9 months ago (2013-03-22 22:10:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12477008/1

7 years, 9 months ago (2013-03-22 23:22:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12477008/1

7 years, 9 months ago (2013-03-23 14:52:47 UTC) #4

Message was sent while issue was closed.

Change committed as 190044

Expand Messages | Collapse Messages