Issue 12477002: [chromedriver] Add chrome package names to adb_commands.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12477002: [chromedriver] Add chrome package names to adb_commands.py. (Closed)

Created:
7 years, 9 months ago by frankf

Modified:
7 years, 9 months ago

Reviewers:
craigdh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Add chrome package names to adb_commands.py. Some minor refactoring. NOTRY=True BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186271

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -32 lines)			Patch
	M	chrome/test/chromedriver/adb_commands.py	View	1	7 chunks	+39 lines, -32 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

craigdh

lgtm with nit. https://codereview.chromium.org/12477002/diff/1/chrome/test/chromedriver/adb_commands.py File chrome/test/chromedriver/adb_commands.py (right): https://codereview.chromium.org/12477002/diff/1/chrome/test/chromedriver/adb_commands.py#newcode26 chrome/test/chromedriver/adb_commands.py:26: PackageInfo('ChromiumTestShellActivity', indent

7 years, 9 months ago (2013-03-05 22:10:20 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/12477002/5001

7 years, 9 months ago (2013-03-05 22:18:43 UTC) #3

Message was sent while issue was closed.

Change committed as 186271

Expand Messages | Collapse Messages

Issue 12477002: [chromedriver] Add chrome package names to adb_commands.py. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages