Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6240)

Unified Diff: chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc

Issue 12476031: Refactor notifications of chrome/browser/webdata (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
diff --git a/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc b/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
index 91b25a9eb4c34faa3204514659fcb7019de6cd2b..7d420f9b97e87751d4c0b4bc7fd1381d5b6e557c 100644
--- a/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
+++ b/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
@@ -38,8 +38,7 @@ using testing::_;
using testing::NiceMock;
using testing::Return;
-// Fake WebDataService implementation that stubs out the database
-// loading.
+// Fake WebDataService implementation that stubs out the database loading.
class FakeWebDataService : public AutofillWebDataService {
public:
FakeWebDataService()
@@ -47,17 +46,11 @@ class FakeWebDataService : public AutofillWebDataService {
NULL, WebDataServiceBase::ProfileErrorCallback()),
is_database_loaded_(false) {}
- // Mark the database as loaded and send out the appropriate
- // notification.
+ // Mark the database as loaded and send out the appropriate notification.
void LoadDatabase() {
StartSyncableService();
is_database_loaded_ = true;
- // TODO(akalin): Expose WDS::NotifyDatabaseLoadedOnUIThread() and
- // use that instead of sending this notification manually.
- content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_WEB_DATABASE_LOADED,
- content::Source<AutofillWebDataService>(this),
- content::NotificationService::NoDetails());
+ NotifyDatabaseLoadedOnUIThread();
}
virtual bool IsDatabaseLoaded() OVERRIDE {

Powered by Google App Engine
This is Rietveld 408576698