Issue 12476026: Disable drive scan on startup to avoid spinning floppy drives

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -19 lines)			Patch
M	chrome/browser/storage_monitor/storage_monitor_win_unittest.cc	View	1 2 3	6 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/storage_monitor/test_volume_mount_watcher_win.h	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/storage_monitor/test_volume_mount_watcher_win.cc	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/storage_monitor/volume_mount_watcher_win.h	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/storage_monitor/volume_mount_watcher_win.cc	View	1 2 3 4	4 chunks	+22 lines, -14 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/12476026/4001

7 years, 9 months ago (2013-03-11 19:44:46 UTC) #3

commit-bot: I haz the power

Failed to trigger a try job on win_rel HTTP Error 400: Bad Request

7 years, 9 months ago (2013-03-11 21:26:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/12476026/5005

7 years, 9 months ago (2013-03-11 21:26:27 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/12476026/3004

7 years, 9 months ago (2013-03-12 16:19:00 UTC) #6

Lei Zhang

On 2013/03/12 21:18:06, I haz the power (commit-bot) wrote: > Change committed as 187647 Yikes. ...

7 years, 9 months ago (2013-03-14 00:15:32 UTC) #8

Greg Billock

7 years, 9 months ago (2013-03-14 01:35:47 UTC) #9

Message was sent while issue was closed.

On 2013/03/14 00:15:32, Lei Zhang wrote:
> On 2013/03/12 21:18:06, I haz the power (commit-bot) wrote:
> > Change committed as 187647
> 
> Yikes. What was committed in patch set 5 contains a lot more changes from what
I
> reviewed. (patch set 1 or 2) Please ping the reviewers and get this
re-reviewed
> or at least send a FYI message.

I was working with SWP owners on this section. We should have been doing
SWP::Shutdown in the unit tests the whole time. (Why it ever worked is one of
the SWP mysteries we don't understand.) I changed to use the task_runner in
order to basically make our usage identical with other clients. (And we were
against a deadline for the canary to test it.)

Expand Messages | Collapse Messages