Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 12476015: apps: Document that switches and pref names should be listed in alphabetical order. (Closed)

Created:
7 years, 9 months ago by tfarina
Modified:
7 years, 9 months ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

apps: Document that switches and pref names should be listed in alphabetical order. And each one should be documented alongside the definition of their values in the source file. R=benwells@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M apps/pref_names.h View 1 chunk +2 lines, -2 lines 0 comments Download
M apps/switches.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
7 years, 9 months ago (2013-03-07 00:28:04 UTC) #1
benwells
lgtm
7 years, 9 months ago (2013-03-07 00:30:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12476015/1
7 years, 9 months ago (2013-03-07 00:38:01 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-07 00:43:46 UTC) #4
Message was sent while issue was closed.
Change committed as 186555

Powered by Google App Engine
This is Rietveld 408576698