chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc - Issue 12475013: bookmarks: Extract PerformBookmarkDrop() function out of bookmark_utils.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

Issue 12475013: bookmarks: Extract PerformBookmarkDrop() function out of bookmark_utils.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: chromeos fixes Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm ('k') | chrome/browser/ui/gtk/bookmarks/bookmark_drag_drop.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

diff --git a/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc b/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

index 6f92e52f4122cedc20d70b452380685805d4c841..a28927fb34866a75334a0db83821ea1793270d4e 100644

--- a/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

+++ b/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

@@ -21,6 +21,7 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/themes/theme_properties.h"

#include "chrome/browser/ui/bookmarks/bookmark_bar_constants.h"

+#include "chrome/browser/ui/bookmarks/bookmark_drag_drop.h"

#include "chrome/browser/ui/bookmarks/bookmark_utils.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/chrome_pages.h"

@@ -1308,11 +1309,8 @@ void BookmarkBarGtk::OnDragReceived(GtkWidget* widget,

gtk_selection_data_get_data(selection_data)), length);

BookmarkNodeData drag_data;

if (drag_data.ReadFromPickle(&pickle)) {

- dnd_success = bookmark_utils::PerformBookmarkDrop(

- browser_->profile(),

- drag_data,

- dest_node,

- index) != ui::DragDropTypes::DRAG_NONE;

+ dnd_success = chrome::DropBookmarks(browser_->profile(),

+ drag_data, dest_node, index) != ui::DragDropTypes::DRAG_NONE;

}

break;

}