Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: lib/src/compiler.dart

Issue 12474009: Fix path bug in windows, don't emit code altogether if we have already seen (Closed) Base URL: git@github.com:dart-lang/web-ui.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/info.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/compiler.dart
diff --git a/lib/src/compiler.dart b/lib/src/compiler.dart
index 82b2832f00624fa318d0b93b59a16f306b21ee48..716cac42a7cfc24ccb19ec383678a8bf3af853a5 100644
--- a/lib/src/compiler.dart
+++ b/lib/src/compiler.dart
@@ -107,7 +107,9 @@ class Compiler {
}
return _parseAndDiscover(_mainPath).then((_) {
_analyze();
+ if (_messages.hasErrors) return;
_transformDart();
+ if (_messages.hasErrors) return;
Jennifer Messerly 2013/03/19 23:36:04 this should clear outputs like the other if below.
Siggi Cherem (dart-lang) 2013/03/19 23:44:53 Done (see below)
_emit();
// TODO(jmesserly): need to go through our errors, and figure out if some
// of them should be warnings instead.
« no previous file with comments | « no previous file | lib/src/info.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698