Fix path bug in windows, don't emit code altogether if we have already seen

Fix path bug in windows, don't emit code altogether if we have already seen
errors.

Committed: https://github.com/dart-lang/web-ui/commit/8cb2a93

[Jennifer Messerly, 2013-03-19 23:36:04]

https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart
File lib/src/compiler.dart (right):

https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart#...
lib/src/compiler.dart:112: if (_messages.hasErrors) return;
this should clear outputs like the other if below. IIRC, _transformDart can emit
files, see _emitModifiedDartFiles.

https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart#...
lib/src/compiler.dart:116: if (_messages.hasErrors) output.clear();
Do we actually emit errors from emit anymore? I bet most of them happen in
_analyze or _transformDart, but I'm not 100% sure.

[Siggi Cherem (dart-lang), 2013-03-19 23:44:53]

https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart
File lib/src/compiler.dart (right):

https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart#...
lib/src/compiler.dart:112: if (_messages.hasErrors) return;
On 2013/03/19 23:36:04, John Messerly wrote:
> this should clear outputs like the other if below. IIRC, _transformDart can
emit
> files, see _emitModifiedDartFiles.

Done (see below)

https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart#...
lib/src/compiler.dart:116: if (_messages.hasErrors) output.clear();
On 2013/03/19 23:36:04, John Messerly wrote:
> Do we actually emit errors from emit anymore? I bet most of them happen in
> _analyze or _transformDart, but I'm not 100% sure.


Now that I think about it, _transformDart can't produce errors either. They are
all during _analyze.

[Jennifer Messerly, 2013-03-19 23:46:44]

lgtm

https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart
File lib/src/compiler.dart (right):

https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart#...
lib/src/compiler.dart:116: if (_messages.hasErrors) output.clear();
On 2013/03/19 23:44:53, Siggi Cherem (dart-lang) wrote:
> On 2013/03/19 23:36:04, John Messerly wrote:
> > Do we actually emit errors from emit anymore? I bet most of them happen in
> > _analyze or _transformDart, but I'm not 100% sure.
> 
> 
> Now that I think about it, _transformDart can't produce errors either. They
are
> all during _analyze.

We might eventually get them from the analyzer. But it isn't hooked up yet, so
not worth worrying about :)

if you don't mind it wouldn't hurt to add a note to dart_parser.dart,
parseCompilationUnit around line 143

[Siggi Cherem (dart-lang), 2013-03-19 23:49:55]

On 2013/03/19 23:46:44, John Messerly wrote:
> lgtm
> 
> https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart
> File lib/src/compiler.dart (right):
> 
>
https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart#...
> lib/src/compiler.dart:116: if (_messages.hasErrors) output.clear();
> On 2013/03/19 23:44:53, Siggi Cherem (dart-lang) wrote:
> > On 2013/03/19 23:36:04, John Messerly wrote:
> > > Do we actually emit errors from emit anymore? I bet most of them happen in
> > > _analyze or _transformDart, but I'm not 100% sure.
> > 
> > 
> > Now that I think about it, _transformDart can't produce errors either. They
> are
> > all during _analyze.
> 
> We might eventually get them from the analyzer. But it isn't hooked up yet, so
> not worth worrying about :)
> 
> if you don't mind it wouldn't hurt to add a note to dart_parser.dart,
> parseCompilationUnit around line 143

good point - done =)

[Siggi Cherem (dart-lang), 2013-03-19 23:55:30]

Committed patchset #3 manually as r8cb2a93 (presubmit successful).