Chromium Code Reviews
Help | Chromium Project | Sign in
(31)

Issue 12474009: Fix path bug in windows, don't emit code altogether if we have already seen (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by Siggi Cherem (dart-lang)
Modified:
2 years, 2 months ago
Reviewers:
John Messerly
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-ui.git@master
Visibility:
Public.

Description

Fix path bug in windows, don't emit code altogether if we have already seen errors. Committed: https://github.com/dart-lang/web-ui/commit/8cb2a93

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M lib/src/compiler.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M lib/src/dart_parser.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M lib/src/info.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 6 (0 generated)
Siggi Cherem (dart-lang)
2 years, 2 months ago (2013-03-19 20:37:14 UTC) #1
John Messerly
https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart File lib/src/compiler.dart (right): https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart#newcode112 lib/src/compiler.dart:112: if (_messages.hasErrors) return; this should clear outputs like the ...
2 years, 2 months ago (2013-03-19 23:36:04 UTC) #2
Siggi Cherem (dart-lang)
https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart File lib/src/compiler.dart (right): https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart#newcode112 lib/src/compiler.dart:112: if (_messages.hasErrors) return; On 2013/03/19 23:36:04, John Messerly wrote: ...
2 years, 2 months ago (2013-03-19 23:44:53 UTC) #3
John Messerly
lgtm https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart File lib/src/compiler.dart (right): https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart#newcode116 lib/src/compiler.dart:116: if (_messages.hasErrors) output.clear(); On 2013/03/19 23:44:53, Siggi Cherem ...
2 years, 2 months ago (2013-03-19 23:46:44 UTC) #4
Siggi Cherem (dart-lang)
On 2013/03/19 23:46:44, John Messerly wrote: > lgtm > > https://chromiumcodereview.appspot.com/12474009/diff/1/lib/src/compiler.dart > File lib/src/compiler.dart (right): ...
2 years, 2 months ago (2013-03-19 23:49:55 UTC) #5
Siggi Cherem (dart-lang)
2 years, 2 months ago (2013-03-19 23:55:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r8cb2a93 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be