Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: sdk/lib/uri/uri_base.dart

Issue 12473003: Remove deprecated StringBuffer.add, addAll and addCharCode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/uri/uri_base.dart
diff --git a/sdk/lib/uri/uri_base.dart b/sdk/lib/uri/uri_base.dart
index c775080c6889c2dbbc65e3dc1194080868b6d6ac..9f228d40056d0d2746ab1227a3969b1cd80a5470 100644
--- a/sdk/lib/uri/uri_base.dart
+++ b/sdk/lib/uri/uri_base.dart
@@ -194,18 +194,18 @@ class Uri {
"origin is applicable to http/https schemes only. Not \'$scheme\'");
}
StringBuffer sb = new StringBuffer();
- sb.add(scheme);
- sb.add(":");
+ sb.write(scheme);
+ sb.write(":");
if (domain == null || domain == "") {
// TODO(aprelev@gmail.com): Use StateException instead
throw new ArgumentError("Cannot use origin without a domain");
}
- sb.add("//");
- sb.add(domain);
+ sb.write("//");
+ sb.write(domain);
if (port != 0) {
- sb.add(":");
- sb.add(port);
+ sb.write(":");
+ sb.write(port);
}
return sb.toString();
}
@@ -214,15 +214,15 @@ class Uri {
StringBuffer sb = new StringBuffer();
_addIfNonEmpty(sb, scheme, scheme, ':');
if (hasAuthority || (scheme == "file")) {
- sb.add("//");
+ sb.write("//");
_addIfNonEmpty(sb, userInfo, userInfo, "@");
- sb.add(domain == null ? "null" : domain);
+ sb.write(domain == null ? "null" : domain);
if (port != 0) {
- sb.add(":");
- sb.add(port.toString());
+ sb.write(":");
+ sb.write(port.toString());
}
}
- sb.add(path == null ? "null" : path);
+ sb.write(path == null ? "null" : path);
_addIfNonEmpty(sb, query, "?", query);
_addIfNonEmpty(sb, fragment, "#", fragment);
return sb.toString();
@@ -252,8 +252,8 @@ class Uri {
static void _addIfNonEmpty(StringBuffer sb, String test,
String first, String second) {
if ("" != test) {
- sb.add(first == null ? "null" : first);
- sb.add(second == null ? "null" : second);
+ sb.write(first == null ? "null" : first);
+ sb.write(second == null ? "null" : second);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698