Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 12473003: Remove deprecated StringBuffer.add, addAll and addCharCode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of ssa; 5 part of ssa;
6 6
7 class SsaCodeGeneratorTask extends CompilerTask { 7 class SsaCodeGeneratorTask extends CompilerTask {
8 8
9 final JavaScriptBackend backend; 9 final JavaScriptBackend backend;
10 10
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 ClassElement enclosingClass = element.getEnclosingClass(); 72 ClassElement enclosingClass = element.getEnclosingClass();
73 73
74 if (element.isInstanceMember() 74 if (element.isInstanceMember()
75 && enclosingClass.isNative() 75 && enclosingClass.isNative()
76 && native.isOverriddenMethod( 76 && native.isOverriddenMethod(
77 element, enclosingClass, nativeEmitter)) { 77 element, enclosingClass, nativeEmitter)) {
78 // Record that this method is overridden. In case of optional 78 // Record that this method is overridden. In case of optional
79 // arguments, the emitter will generate stubs to handle them, 79 // arguments, the emitter will generate stubs to handle them,
80 // and needs to know if the method is overridden. 80 // and needs to know if the method is overridden.
81 nativeEmitter.overriddenMethods.add(element); 81 nativeEmitter.overriddenMethods.add(element);
82 StringBuffer buffer = new StringBuffer(); 82 body = nativeEmitter.generateMethodBodyWithPrototypeCheckForElement(
83 body = 83 element, codegen.body, codegen.parameters);
84 nativeEmitter.generateMethodBodyWithPrototypeCheckForElement(
85 element, codegen.body, codegen.parameters);
86 } else { 84 } else {
87 body = codegen.body; 85 body = codegen.body;
88 } 86 }
89 87
90 return buildJavaScriptFunction(element, codegen.parameters, body); 88 return buildJavaScriptFunction(element, codegen.parameters, body);
91 }); 89 });
92 } 90 }
93 91
94 js.Expression generateBailoutMethod(CodegenWorkItem work, HGraph graph) { 92 js.Expression generateBailoutMethod(CodegenWorkItem work, HGraph graph) {
95 return measure(() { 93 return measure(() {
(...skipping 2869 matching lines...) Expand 10 before | Expand all | Expand 10 after
2965 if (leftType.canBeNull() && rightType.canBeNull()) { 2963 if (leftType.canBeNull() && rightType.canBeNull()) {
2966 if (left.isConstantNull() || right.isConstantNull() || 2964 if (left.isConstantNull() || right.isConstantNull() ||
2967 (leftType.isPrimitive() && leftType == rightType)) { 2965 (leftType.isPrimitive() && leftType == rightType)) {
2968 return '=='; 2966 return '==';
2969 } 2967 }
2970 return null; 2968 return null;
2971 } else { 2969 } else {
2972 return '==='; 2970 return '===';
2973 } 2971 }
2974 } 2972 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698