chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java - Issue 1247033009: Clean up Enhanced Bookmark's data acquiring logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java

Issue 1247033009: Clean up Enhanced Bookmark's data acquiring logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@icon_eb

Patch Set: Add correct files to git commits Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkDrawerListView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFolderSelectActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java

index f1244d606d45ed8819a49f0ecd475cf1fb099dc8..5b68ae1245a4cee6b0bcd393269b4a84de5c15f0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java

@@ -15,7 +15,6 @@ import org.chromium.chrome.R;

import org.chromium.chrome.browser.BookmarksBridge.BookmarkItem;

import org.chromium.chrome.browser.BookmarksBridge.BookmarkModelObserver;

import org.chromium.chrome.browser.UrlUtilities;

-import org.chromium.chrome.browser.enhanced_bookmarks.EnhancedBookmarksModel;

import org.chromium.chrome.browser.widget.EmptyAlertEditText;

import org.chromium.chrome.browser.widget.TintedDrawable;

import org.chromium.components.bookmarks.BookmarkId;

@@ -75,7 +74,7 @@ public class EnhancedBookmarkEditActivity extends EnhancedBookmarkActivityBase {

mEnhancedBookmarksModel = new EnhancedBookmarksModel();

mBookmarkId = BookmarkId.getBookmarkIdFromString(

getIntent().getStringExtra(INTENT_BOOKMARK_ID));

- mEnhancedBookmarksModel.addModelObserver(mBookmarkModelObserver);

+ mEnhancedBookmarksModel.addObserver(mBookmarkModelObserver);

setContentView(R.layout.eb_edit);

mTitleEditText = (EmptyAlertEditText) findViewById(R.id.title_text);

@@ -143,7 +142,7 @@ public class EnhancedBookmarkEditActivity extends EnhancedBookmarkActivityBase {

@Override

protected void onDestroy() {

- mEnhancedBookmarksModel.removeModelObserver(mBookmarkModelObserver);

+ mEnhancedBookmarksModel.removeObserver(mBookmarkModelObserver);

mEnhancedBookmarksModel.destroy();

mEnhancedBookmarksModel = null;

super.onDestroy();