chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java - Issue 1247033009: Clean up Enhanced Bookmark's data acquiring logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java

Issue 1247033009: Clean up Enhanced Bookmark's data acquiring logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@icon_eb

Patch Set: Add correct files to git commits Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/OWNERS ('k') | chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkAddEditFolderActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java

index 23da34a5d9d8b0ad456fe19bf2646493bbbc3f40..c5136865bad094b9dcb3f7252e83676cc7a3994c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java

@@ -18,7 +18,6 @@ import android.view.View.OnClickListener;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.BookmarksBridge.BookmarkItem;

import org.chromium.chrome.browser.BookmarksBridge.BookmarkModelObserver;

-import org.chromium.chrome.browser.enhanced_bookmarks.EnhancedBookmarksModel;

import org.chromium.chrome.browser.widget.NumberRollView;

import org.chromium.components.bookmarks.BookmarkId;

import org.chromium.components.bookmarks.BookmarkType;

@@ -190,13 +189,13 @@ public class EnhancedBookmarkActionBar extends Toolbar implements EnhancedBookma

public void onEnhancedBookmarkDelegateInitialized(EnhancedBookmarkDelegate delegate) {

mDelegate = delegate;

mDelegate.addUIObserver(this);

- delegate.getModel().addModelObserver(mBookmarkModelObserver);

+ delegate.getModel().addObserver(mBookmarkModelObserver);

}

@Override

public void onDestroy() {

mDelegate.removeUIObserver(this);

- mDelegate.getModel().removeModelObserver(mBookmarkModelObserver);

+ mDelegate.getModel().removeObserver(mBookmarkModelObserver);

}

@Override