Issue 12466005: Do not use a relative path to launch the import process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12466005: Do not use a relative path to launch the import process. (Closed)

Created:
7 years, 9 months ago by gab

Modified:
7 years, 9 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not use a relative path to launch the import process. Chrome already changes the CWD to its directory when loading (in LoadChromeWithDirectory()); thus if the command-line used a relative path, that relative path is no longer valid. BUG=DCHECK because of failed import when running out\Debug\chrome.exe --force-first-run Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186367

Patch Set 1 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	chrome/browser/first_run/first_run_win.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12466005/2001

7 years, 9 months ago (2013-03-06 03:31:47 UTC) #3

Message was sent while issue was closed.

Change committed as 186367

Expand Messages | Collapse Messages