Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 12465005: Define ui::ScopedAnimatonDurationScaleMode (Closed)

Created:
7 years, 9 months ago by ajuma
Modified:
7 years, 9 months ago
Reviewers:
Ian Vollick, sky
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, tfarina, jonathan.backer, oshima+watch_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Define ui::ScopedAnimatonDurationScaleMode This allows animations to be sped up or slowed down for testing or debugging. This replaces LayerAnimator::slow_animation_mode and LayerAnimator::disable_animations_for_tests. BUG=129683 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187765

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fix nit #

Total comments: 5

Patch Set 3 : Address sky's comments #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -121 lines) Patch
M ash/desktop_background/desktop_background_controller_unittest.cc View 1 2 14 chunks +43 lines, -29 lines 0 comments Download
M ash/launcher/launcher_view.cc View 1 2 3 3 chunks +6 lines, -17 lines 0 comments Download
M ash/test/ash_test_base.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ash/wm/custom_frame_view_ash.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M ash/wm/power_button_controller_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ash/wm/session_state_controller_impl2_unittest.cc View 1 2 4 chunks +8 lines, -3 lines 0 comments Download
M ash/wm/window_animations_unittest.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_manager_unittest.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker_browsertest.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/immersive_mode_controller_browsertest.cc View 1 2 3 3 chunks +5 lines, -2 lines 0 comments Download
M ui/aura/test/aura_test_helper.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ui/aura/window_unittest.cc View 1 2 3 4 chunks +7 lines, -3 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/compositor/layer_animation_element.cc View 1 2 3 2 chunks +20 lines, -7 lines 0 comments Download
M ui/compositor/layer_animator.h View 1 2 2 chunks +0 lines, -32 lines 0 comments Download
M ui/compositor/layer_animator.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M ui/compositor/layer_animator_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
A ui/compositor/scoped_animation_duration_scale_mode.h View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
A ui/compositor/scoped_animation_duration_scale_mode.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M ui/views/corewm/visibility_controller_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/corewm/window_animations_unittest.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
ajuma
This is needed by https://chromiumcodereview.appspot.com/12226080 in order to speed up animations for a test that ...
7 years, 9 months ago (2013-03-05 19:07:53 UTC) #1
Ian Vollick
I love it. Setting scale modes with descriptive names is so much better than disable_animations_for_test. ...
7 years, 9 months ago (2013-03-06 01:16:21 UTC) #2
ajuma
+sky for ash, chrome, ui/aura, and ui/views OWNERS. https://chromiumcodereview.appspot.com/12465005/diff/2001/ui/compositor/layer_animator.h File ui/compositor/layer_animator.h (right): https://chromiumcodereview.appspot.com/12465005/diff/2001/ui/compositor/layer_animator.h#newcode205 ui/compositor/layer_animator.h:205: static ...
7 years, 9 months ago (2013-03-06 18:12:34 UTC) #3
sky
https://codereview.chromium.org/12465005/diff/7001/ash/desktop_background/desktop_background_controller_unittest.cc File ash/desktop_background/desktop_background_controller_unittest.cc (right): https://codereview.chromium.org/12465005/diff/7001/ash/desktop_background/desktop_background_controller_unittest.cc#newcode39 ash/desktop_background/desktop_background_controller_unittest.cc:39: DCHECK(ui::LayerAnimator::duration_scale_mode() != Sorry, you're changing this so you get ...
7 years, 9 months ago (2013-03-07 20:56:25 UTC) #4
tfarina
https://codereview.chromium.org/12465005/diff/7001/ash/desktop_background/desktop_background_controller_unittest.cc File ash/desktop_background/desktop_background_controller_unittest.cc (right): https://codereview.chromium.org/12465005/diff/7001/ash/desktop_background/desktop_background_controller_unittest.cc#newcode39 ash/desktop_background/desktop_background_controller_unittest.cc:39: DCHECK(ui::LayerAnimator::duration_scale_mode() != On 2013/03/07 20:56:25, sky wrote: > Sorry, ...
7 years, 9 months ago (2013-03-07 21:04:26 UTC) #5
tfarina
A more precise command line is: $ g gs "DCHECK(" | egrep ".*_(unit|browser|api)test\.cc" | wc ...
7 years, 9 months ago (2013-03-07 21:21:44 UTC) #6
ajuma
https://codereview.chromium.org/12465005/diff/7001/ash/desktop_background/desktop_background_controller_unittest.cc File ash/desktop_background/desktop_background_controller_unittest.cc (right): https://codereview.chromium.org/12465005/diff/7001/ash/desktop_background/desktop_background_controller_unittest.cc#newcode39 ash/desktop_background/desktop_background_controller_unittest.cc:39: DCHECK(ui::LayerAnimator::duration_scale_mode() != On 2013/03/07 20:56:25, sky wrote: > Sorry, ...
7 years, 9 months ago (2013-03-08 21:09:21 UTC) #7
Ian Vollick
On 2013/03/08 21:09:21, ajuma wrote: > https://codereview.chromium.org/12465005/diff/7001/ash/desktop_background/desktop_background_controller_unittest.cc > File ash/desktop_background/desktop_background_controller_unittest.cc (right): > > https://codereview.chromium.org/12465005/diff/7001/ash/desktop_background/desktop_background_controller_unittest.cc#newcode39 > ...
7 years, 9 months ago (2013-03-12 18:18:45 UTC) #8
sky
Thank you, LGTM
7 years, 9 months ago (2013-03-12 21:19:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/12465005/22001
7 years, 9 months ago (2013-03-12 21:34:24 UTC) #10
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/views/immersive_mode_controller_browsertest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 9 months ago (2013-03-12 21:34:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/12465005/31002
7 years, 9 months ago (2013-03-12 21:46:33 UTC) #12
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=18843
7 years, 9 months ago (2013-03-13 00:36:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/12465005/31002
7 years, 9 months ago (2013-03-13 01:28:55 UTC) #14
commit-bot: I haz the power
7 years, 9 months ago (2013-03-13 04:08:39 UTC) #15
Message was sent while issue was closed.
Change committed as 187765

Powered by Google App Engine
This is Rietveld 408576698