content/browser/webui/web_ui_impl.h - Issue 12463042: Shows chrome-extension urls and greys out the whole url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/webui/web_ui_impl.h

Issue 12463042: Shows chrome-extension urls and greys out the whole url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed comment nits Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/omnibox/omnibox_view_win.cc ('K') | « chrome/browser/ui/views/omnibox/omnibox_view_win.cc ('k') | content/browser/webui/web_ui_impl.cc » ('j') | content/public/browser/web_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/webui/web_ui_impl.h

diff --git a/content/browser/webui/web_ui_impl.h b/content/browser/webui/web_ui_impl.h

index 49d9b4bb72808ac8afaee15d696db46073b2a1b3..00d085c824b7ffe778accbd6f1334073fbfb8053 100644

--- a/content/browser/webui/web_ui_impl.h

+++ b/content/browser/webui/web_ui_impl.h

@@ -38,6 +38,8 @@ class CONTENT_EXPORT WebUIImpl : public WebUI,

virtual void FocusLocationBarByDefault() OVERRIDE;

virtual bool ShouldHideURL() const OVERRIDE;

virtual void HideURL() OVERRIDE;

+ virtual bool ShouldGreyOutURL() const OVERRIDE;

+ virtual void GreyOutURL() OVERRIDE;

virtual const string16& GetOverriddenTitle() const OVERRIDE;

virtual void OverrideTitle(const string16& title) OVERRIDE;

virtual PageTransition GetLinkTransitionType() const OVERRIDE;

@@ -94,6 +96,7 @@ class CONTENT_EXPORT WebUIImpl : public WebUI,

bool hide_favicon_;

bool focus_location_bar_by_default_;

bool should_hide_url_;

+ bool should_grey_out_url_;

string16 overridden_title_; // Defaults to empty string.

PageTransition link_transition_type_; // Defaults to LINK.

int bindings_; // The bindings from BindingsPolicy that should be enabled for