chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm - Issue 12463042: Shows chrome-extension urls and greys out the whole url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 12463042: Shows chrome-extension urls and greys out the whole url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed comment nits Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_web_ui.cc ('k') | chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc » ('j') | chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

index 751ef89474793eec231cadc88bfa6c0baf1dadaf..9d4c1a99367d071d61d7b6447bdb2e253d9a69e3 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

@@ -455,8 +455,10 @@ void OmniboxViewMac::ApplyTextAttributes(const string16& display_text,

[as addAttribute:NSForegroundColorAttributeName value:BaseTextColor()

range:as_entire_string];

- [as addAttribute:NSForegroundColorAttributeName value:HostTextColor()

+ if (!toolbar_model()->ShouldGreyOutURL()) {

+ [as addAttribute:NSForegroundColorAttributeName value:HostTextColor()

range:ComponentToNSRange(host)];

+ }

}

// TODO(shess): GTK has this as a member var, figure out why.