Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3686)

Unified Diff: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

Issue 12463042: Shows chrome-extension urls and greys out the whole url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Not hacky anymore Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
diff --git a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
index 0bb0c6eb05de4f72ee6da0b4397e34c89da940a2..36f86573031f635244b439499f8a89720ae41ca0 100644
--- a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
+++ b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
@@ -1649,15 +1649,18 @@ void OmniboxViewGtk::EmphasizeURLComponents() {
if (emphasize) {
gtk_text_buffer_apply_tag(text_buffer_, faded_text_tag_, &start, &end);
- // We've found a host name, give it more emphasis.
- gtk_text_buffer_get_iter_at_line_index(text_buffer_, &start, 0,
+ if (!toolbar_model()->ShouldNotEmphasizeHost()) {
+
Devlin 2013/03/27 15:59:52 remove extra newline.
Patrick Riordan 2013/03/27 19:43:28 Done.
+ // We've found a host name, give it more emphasis.
+ gtk_text_buffer_get_iter_at_line_index(text_buffer_, &start, 0,
GetUTF8Offset(text,
Devlin 2013/03/27 15:59:52 Need to fix line wrapping.
Patrick Riordan 2013/03/27 19:43:28 Done.
host.begin));
- gtk_text_buffer_get_iter_at_line_index(text_buffer_, &end, 0,
+ gtk_text_buffer_get_iter_at_line_index(text_buffer_, &end, 0,
GetUTF8Offset(text,
host.end()));
- gtk_text_buffer_apply_tag(text_buffer_, normal_text_tag_, &start, &end);
+ gtk_text_buffer_apply_tag(text_buffer_, normal_text_tag_, &start, &end);
+ }
} else {
gtk_text_buffer_apply_tag(text_buffer_, normal_text_tag_, &start, &end);
}

Powered by Google App Engine
This is Rietveld 408576698