Shows chrome-extension urls and greys out the whole url.

chrome/browser/extensions/extension_web_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_web_ui.h"
 
 #include <set>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 113 matching lines @@
     "extensions.chrome_url_overrides";
 
 ExtensionWebUI::ExtensionWebUI(content::WebUI* web_ui, const GURL& url)
     : WebUIController(web_ui),
       url_(url) {
   Profile* profile = Profile::FromWebUI(web_ui);
   ExtensionService* service = profile->GetExtensionService();
   const Extension* extension =
       service->extensions()->GetExtensionOrAppByURL(ExtensionURLInfo(url));
   DCHECK(extension);
-  // Only hide the url for internal pages (e.g. chrome-extension or packaged
-  // component apps like bookmark manager.
-  bool should_hide_url = !extension->is_hosted_app();
+  // Only grey out the entire url for internal pages (e.g. chrome-extension or
+  // packaged component apps like bookmark manager).
+  bool should_grey_out_url = !extension->is_hosted_app();
 
   // The base class defaults to enabling WebUI bindings, but we don't need
   // those (this is also reflected in ChromeWebUIControllerFactory::
   // UseWebUIBindingsForURL).
   int bindings = 0;
 
   // Bind externalHost to Extension WebUI loaded in Chrome Frame.
   const CommandLine& browser_command_line = *CommandLine::ForCurrentProcess();
   if (browser_command_line.HasSwitch(switches::kChromeFrame))
     bindings |= content::BINDINGS_POLICY_EXTERNAL_HOST;
   // For chrome:// overrides, some of the defaults are a little different.
   GURL effective_url = web_ui->GetWebContents()->GetURL();
   if (effective_url.SchemeIs(chrome::kChromeUIScheme)) {
     if (effective_url.host() == chrome::kChromeUINewTabHost) {
       web_ui->FocusLocationBarByDefault();
     } else {
-      // Current behavior of other chrome:// pages is to display the URL.
-      should_hide_url = false;
+      // Current behavior of other chrome:// pages is to emphasize host,

[Devlin, 2013/04/01 20:35:28]

"emphasize the host"

[Patrick Riordan, 2013/04/03 00:19:00]

Done.

+      // which means we shouldn't grey out the entire url.
+      should_grey_out_url = false;
     }
   }
 
-  if (should_hide_url)
-    web_ui->HideURL();
+  if (should_grey_out_url)
+    web_ui->GreyOutURL();
 
   web_ui->SetBindings(bindings);
 
   // Hack: A few things we specialize just for the bookmark manager.
   if (extension->id() == extension_misc::kBookmarkManagerId) {
     bookmark_manager_private_event_router_.reset(
         new extensions::BookmarkManagerPrivateEventRouter(
             profile, web_ui->GetWebContents()));
 
     web_ui->SetLinkTransitionType(content::PAGE_TRANSITION_AUTO_BOOKMARK);
@@ skipping 261 matching lines @@
             extensions::ImageLoader::ImageRepresentation::ALWAYS_RESIZE,
             gfx::Size(pixel_size, pixel_size),
             scale_factors[i]));
   }
 
   // LoadImagesAsync actually can run callback synchronously. We want to force
   // async.
   extensions::ImageLoader::Get(profile)->LoadImagesAsync(
       extension, info_list, base::Bind(&RunFaviconCallbackAsync, callback));
 }