Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 12463015: Enable <adview> tag for packaged apps. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Merge fix. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/json/json_file_value_serializer.h" 6 #include "base/json/json_file_value_serializer.h"
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/common/chrome_paths.h" 10 #include "chrome/common/chrome_paths.h"
(...skipping 642 matching lines...) Expand 10 before | Expand all | Expand 10 after
653 } 653 }
654 654
655 TEST_F(PermissionsTest, PermissionMessages) { 655 TEST_F(PermissionsTest, PermissionMessages) {
656 // Ensure that all permissions that needs to show install UI actually have 656 // Ensure that all permissions that needs to show install UI actually have
657 // strings associated with them. 657 // strings associated with them.
658 APIPermissionSet skip; 658 APIPermissionSet skip;
659 659
660 // These are considered "nuisance" or "trivial" permissions that don't need 660 // These are considered "nuisance" or "trivial" permissions that don't need
661 // a prompt. 661 // a prompt.
662 skip.insert(APIPermission::kActiveTab); 662 skip.insert(APIPermission::kActiveTab);
663 skip.insert(APIPermission::kAdView);
663 skip.insert(APIPermission::kAlarms); 664 skip.insert(APIPermission::kAlarms);
664 skip.insert(APIPermission::kAppCurrentWindowInternal); 665 skip.insert(APIPermission::kAppCurrentWindowInternal);
665 skip.insert(APIPermission::kAppRuntime); 666 skip.insert(APIPermission::kAppRuntime);
666 skip.insert(APIPermission::kAppWindow); 667 skip.insert(APIPermission::kAppWindow);
667 skip.insert(APIPermission::kBrowsingData); 668 skip.insert(APIPermission::kBrowsingData);
668 skip.insert(APIPermission::kContextMenus); 669 skip.insert(APIPermission::kContextMenus);
669 skip.insert(APIPermission::kFontSettings); 670 skip.insert(APIPermission::kFontSettings);
670 skip.insert(APIPermission::kFullscreen); 671 skip.insert(APIPermission::kFullscreen);
671 skip.insert(APIPermission::kIdle); 672 skip.insert(APIPermission::kIdle);
672 skip.insert(APIPermission::kNotification); 673 skip.insert(APIPermission::kNotification);
(...skipping 698 matching lines...) Expand 10 before | Expand all | Expand 10 after
1371 apis.insert(APIPermission::kWebRequest); 1372 apis.insert(APIPermission::kWebRequest);
1372 apis.insert(APIPermission::kFileBrowserHandler); 1373 apis.insert(APIPermission::kFileBrowserHandler);
1373 EXPECT_EQ(2U, apis.size()); 1374 EXPECT_EQ(2U, apis.size());
1374 1375
1375 scoped_refptr<PermissionSet> perm_set; 1376 scoped_refptr<PermissionSet> perm_set;
1376 perm_set = new PermissionSet(apis, empty_extent, empty_extent); 1377 perm_set = new PermissionSet(apis, empty_extent, empty_extent);
1377 EXPECT_EQ(4U, perm_set->apis().size()); 1378 EXPECT_EQ(4U, perm_set->apis().size());
1378 } 1379 }
1379 1380
1380 } // namespace extensions 1381 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/common/extensions/permissions/api_permission.cc ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698