Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 12462010: Changing GetTestFilePath so we can place test files outside of the chromeos directory. (Closed)

Created:
7 years, 9 months ago by keishi
Modified:
7 years, 9 months ago
Reviewers:
hidehiko, satorux1, tzik
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, derat+watch_chromium.org, achuith+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, oshima+watch_chromium.org, tzik+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Changing GetTestFilePath so we can place test files outside of the chromeos directory. BUG=176884 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -297 lines) Patch
M chrome/browser/chromeos/contacts/gdata_contacts_service_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_unittest.cc View 3 chunks +21 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_cache_unittest.cc View 21 chunks +24 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system_unittest.cc View 63 chunks +83 lines, -74 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_scheduler_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_webapps_registry_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_directory_operation_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_entry_conversion_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/search_metadata_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/stale_cache_files_remover_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/net/onc_utils_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/google_apis/base_operations_server_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/google_apis/drive_api_operations_unittest.cc View 9 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/google_apis/drive_api_parser_unittest.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/google_apis/fake_drive_service_unittest.cc View 58 chunks +112 lines, -60 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations_unittest.cc View 16 chunks +20 lines, -19 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_parser_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/test_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/test_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc View 20 chunks +48 lines, -33 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_mock_unittest.cc View 14 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
keishi
Reposting Issue 12463009 because Base URL was wrong. Please LGTM this one again.
7 years, 9 months ago (2013-03-08 08:12:55 UTC) #1
satorux1
LGTM
7 years, 9 months ago (2013-03-08 08:42:19 UTC) #2
hidehiko
lgtm
7 years, 9 months ago (2013-03-08 08:45:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/12462010/1
7 years, 9 months ago (2013-03-08 10:23:08 UTC) #4
commit-bot: I haz the power
Presubmit check for 12462010-1 failed and returned exit status 1. INFO:root:Found 22 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-08 10:23:21 UTC) #5
kinuko
> ** Presubmit ERRORS ** > Missing LGTM from an OWNER for these files: > ...
7 years, 9 months ago (2013-03-08 11:12:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/12462010/1
7 years, 9 months ago (2013-03-08 12:00:20 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-08 14:12:40 UTC) #8
Message was sent while issue was closed.
Change committed as 186958

Powered by Google App Engine
This is Rietveld 408576698