Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12461008: Modify metrics_private extensions api to use JSON Schema Compiler (Closed)

Created:
7 years, 9 months ago by Aaron Jacobs
Modified:
7 years, 9 months ago
Reviewers:
Devlin, cduvall, Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Modify metrics_private extensions api to use JSON Schema Compiler BUG=121174 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190042

Patch Set 1 #

Total comments: 2

Patch Set 2 : cduvall's requests #

Patch Set 3 : Merged with master #

Patch Set 4 : Removed AUTHORS file change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -47 lines) Patch
M chrome/browser/extensions/api/metrics_private/metrics_private_api.cc View 1 3 chunks +55 lines, -47 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Aaron Jacobs
7 years, 9 months ago (2013-03-05 19:19:25 UTC) #1
cduvall
https://codereview.chromium.org/12461008/diff/1/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc File chrome/browser/extensions/api/metrics_private/metrics_private_api.cc (right): https://codereview.chromium.org/12461008/diff/1/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc#newcode14 chrome/browser/extensions/api/metrics_private/metrics_private_api.cc:14: namespace RecordUserAction = extensions::api::metrics_private::RecordUserAction; Move these into the namespace ...
7 years, 9 months ago (2013-03-05 21:13:42 UTC) #2
Aaron Jacobs
https://codereview.chromium.org/12461008/diff/1/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc File chrome/browser/extensions/api/metrics_private/metrics_private_api.cc (right): https://codereview.chromium.org/12461008/diff/1/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc#newcode14 chrome/browser/extensions/api/metrics_private/metrics_private_api.cc:14: namespace RecordUserAction = extensions::api::metrics_private::RecordUserAction; On 2013/03/05 21:13:42, cduvall wrote: ...
7 years, 9 months ago (2013-03-05 22:28:36 UTC) #3
cduvall
lgtm
7 years, 9 months ago (2013-03-22 00:44:11 UTC) #4
Aaron Jacobs
+yoz please take a look (and thanks for the info on issue tense, I'll make ...
7 years, 9 months ago (2013-03-22 17:14:23 UTC) #5
Yoyo Zhou
LGTM
7 years, 9 months ago (2013-03-22 18:22:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Samusaaron3@gmail.com/12461008/18001
7 years, 9 months ago (2013-03-22 20:34:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Samusaaron3@gmail.com/12461008/18001
7 years, 9 months ago (2013-03-23 14:50:40 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-03-23 17:37:22 UTC) #9
Message was sent while issue was closed. 
Change committed as 190042

Powered by Google App Engine
This is Rietveld 408576698