Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: src/trusted/service_runtime/nacl_config.h

Issue 12460003: [MIPS] Leave room for frame header on stack for MIPS arch (Closed) Base URL: http://git.chromium.org/native_client/src/native_client.git@master
Patch Set: Rename NACL_STACK_ARG_SIZE to NACL_STACK_ARGS_SIZE. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/trusted/service_runtime/nacl_syscall_common.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/service_runtime/nacl_config.h
diff --git a/src/trusted/service_runtime/nacl_config.h b/src/trusted/service_runtime/nacl_config.h
index c6309b8836258cc9dafb7ff7b5b2c69b9ef5eb0a..c8a9e8897b36f1b48dd36e7a5d612c68661d86e8 100644
--- a/src/trusted/service_runtime/nacl_config.h
+++ b/src/trusted/service_runtime/nacl_config.h
@@ -184,6 +184,7 @@
* must do so here as well.
*/
# define NACL_STACK_ALIGN_MASK (0xf)
+# define NACL_STACK_ARGS_SIZE (0)
# define NACL_STACK_GETS_ARG (1)
# define NACL_STACK_PAD_BELOW_ALIGN (4)
# define NACL_STACK_RED_ZONE (0)
@@ -204,6 +205,7 @@
* 3.2.2 discusses stack alignment.
*/
# define NACL_STACK_ALIGN_MASK (0xf)
+# define NACL_STACK_ARGS_SIZE (0)
# define NACL_STACK_GETS_ARG (0)
# define NACL_STACK_PAD_BELOW_ALIGN (8)
# define NACL_STACK_RED_ZONE (128)
@@ -239,6 +241,7 @@
* performance of vector instructions, we increase this to 16.
*/
# define NACL_STACK_ALIGN_MASK (0xf)
+# define NACL_STACK_ARGS_SIZE (0)
# define NACL_STACK_GETS_ARG (0)
# define NACL_STACK_PAD_BELOW_ALIGN (0)
# define NACL_STACK_RED_ZONE (0)
@@ -270,6 +273,11 @@
# define NACL_USERRET_FIX (-0x4)
# define NACL_SYSARGS_FIX (0)
# define NACL_STACK_ALIGN_MASK (0x7)
+/*
+ * The MIPS o32 ABI requires callers to reserve 16 bytes above the stack
+ * pointer, which the callee can spill arguments to.
+ */
+# define NACL_STACK_ARGS_SIZE (0x10)
# define NACL_STACK_GETS_ARG (0)
# define NACL_STACK_PAD_BELOW_ALIGN (0)
# define NACL_STACK_RED_ZONE (0)
« no previous file with comments | « no previous file | src/trusted/service_runtime/nacl_syscall_common.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698