src/isolate.cc - Issue 12459011: Avoid bool to Oddball conversions by being lazy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 12459011: Avoid bool to Oddball conversions by being lazy. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index 5e61761c94ac7bdcefb4f7776c02af6c0c6f2569..f56f99b8f6d7355698f62f998191e0ac26dfb642 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -754,7 +754,7 @@ Handle<JSArray> Isolate::CaptureCurrentStackTrace(

if (options & StackTrace::kFunctionName) {

Handle<Object> fun_name(fun->shared()->name(), this);

- if (fun_name->ToBoolean()->IsFalse()) {

+ if (!fun_name->BooleanValue()) {

fun_name = Handle<Object>(fun->shared()->inferred_name(), this);

}

CHECK_NOT_EMPTY_HANDLE(this,

« no previous file with comments | « src/execution.cc ('k') | src/objects.h » ('j') | no next file with comments »