Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: runtime/vm/stack_frame.cc

Issue 12457034: Ensure that all goto instructions have deoptimization target. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Delete UNREACHABLE Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stack_frame.cc
diff --git a/runtime/vm/stack_frame.cc b/runtime/vm/stack_frame.cc
index 47a72d2ad1d43611b9296c8fe0f3ecc9ee939b41..3ae8d3321ced206ba6ac3ceecfcd63d981fb10e0 100644
--- a/runtime/vm/stack_frame.cc
+++ b/runtime/vm/stack_frame.cc
@@ -332,11 +332,8 @@ void InlinedFunctionsIterator::Advance() {
ASSERT(deopt_instructions_.length() != 0);
while (index_ < deopt_instructions_.length()) {
DeoptInstr* deopt_instr = deopt_instructions_[index_++];
- ASSERT(deopt_instr->kind() != DeoptInstr::kRetBeforeAddress);
- if (deopt_instr->kind() == DeoptInstr::kRetAfterAddress) {
- pc_ = DeoptInstr::GetRetAfterAddress(deopt_instr,
- object_table_,
- &func);
+ if (deopt_instr->kind() == DeoptInstr::kRetAddress) {
+ pc_ = DeoptInstr::GetRetAddress(deopt_instr, object_table_, &func);
code_ = func.unoptimized_code();
function_ = func.raw();
return;
« no previous file with comments | « runtime/vm/object_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698