Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: runtime/vm/deopt_instructions.h

Issue 12457034: Ensure that all goto instructions have deoptimization target. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Delete UNREACHABLE Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/deopt_instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/deopt_instructions.h
diff --git a/runtime/vm/deopt_instructions.h b/runtime/vm/deopt_instructions.h
index 7967aa940a4313183ddd9099c6b9870dda8b8b04..b434bf7054d76acdbe65400442bd47460f30f897 100644
--- a/runtime/vm/deopt_instructions.h
+++ b/runtime/vm/deopt_instructions.h
@@ -95,8 +95,7 @@ class DeoptimizationContext : public ValueObject {
class DeoptInstr : public ZoneAllocated {
public:
enum Kind {
- kRetAfterAddress,
- kRetBeforeAddress,
+ kRetAddress,
kConstant,
kRegister,
kFpuRegister,
@@ -136,9 +135,9 @@ class DeoptInstr : public ZoneAllocated {
// Get the function and return address which is encoded in this
// kRetAfterAddress deopt instruction.
- static uword GetRetAfterAddress(DeoptInstr* instr,
- const Array& object_table,
- Function* func);
+ static uword GetRetAddress(DeoptInstr* instr,
+ const Array& object_table,
+ Function* func);
protected:
virtual intptr_t from_index() const = 0;
@@ -164,14 +163,9 @@ class DeoptInfoBuilder : public ValueObject {
const GrowableObjectArray& object_table() { return object_table_; }
// Return address before instruction.
- void AddReturnAddressBefore(const Function& function,
- intptr_t deopt_id,
- intptr_t to_index);
-
- // Return address after instruction.
- void AddReturnAddressAfter(const Function& function,
- intptr_t deopt_id,
- intptr_t to_index);
+ void AddReturnAddress(const Function& function,
+ intptr_t deopt_id,
+ intptr_t to_index);
// Copy from optimized frame to unoptimized.
void AddCopy(const Location& from_loc, intptr_t to_index);
« no previous file with comments | « no previous file | runtime/vm/deopt_instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698