Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: runtime/vm/stack_frame.cc

Issue 12457034: Ensure that all goto instructions have deoptimization target. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Delete UNREACHABLE Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/object_test.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/stack_frame.h" 5 #include "vm/stack_frame.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/deopt_instructions.h" 8 #include "vm/deopt_instructions.h"
9 #include "vm/isolate.h" 9 #include "vm/isolate.h"
10 #include "vm/object.h" 10 #include "vm/object.h"
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 325
326 if (deopt_info_.IsNull()) { 326 if (deopt_info_.IsNull()) {
327 SetDone(); 327 SetDone();
328 return; 328 return;
329 } 329 }
330 330
331 Function& func = Function::Handle(); 331 Function& func = Function::Handle();
332 ASSERT(deopt_instructions_.length() != 0); 332 ASSERT(deopt_instructions_.length() != 0);
333 while (index_ < deopt_instructions_.length()) { 333 while (index_ < deopt_instructions_.length()) {
334 DeoptInstr* deopt_instr = deopt_instructions_[index_++]; 334 DeoptInstr* deopt_instr = deopt_instructions_[index_++];
335 ASSERT(deopt_instr->kind() != DeoptInstr::kRetBeforeAddress); 335 if (deopt_instr->kind() == DeoptInstr::kRetAddress) {
336 if (deopt_instr->kind() == DeoptInstr::kRetAfterAddress) { 336 pc_ = DeoptInstr::GetRetAddress(deopt_instr, object_table_, &func);
337 pc_ = DeoptInstr::GetRetAfterAddress(deopt_instr,
338 object_table_,
339 &func);
340 code_ = func.unoptimized_code(); 337 code_ = func.unoptimized_code();
341 function_ = func.raw(); 338 function_ = func.raw();
342 return; 339 return;
343 } 340 }
344 } 341 }
345 SetDone(); 342 SetDone();
346 } 343 }
347 344
348 } // namespace dart 345 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/object_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698