Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Side by Side Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 12457034: Ensure that all goto instructions have deoptimization target. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Delete UNREACHABLE Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 const String& dst_name, 141 const String& dst_name,
142 LocationSummary* locs) { 142 LocationSummary* locs) {
143 UNIMPLEMENTED(); 143 UNIMPLEMENTED();
144 } 144 }
145 145
146 146
147 void FlowGraphCompiler::EmitInstructionPrologue(Instruction* instr) { 147 void FlowGraphCompiler::EmitInstructionPrologue(Instruction* instr) {
148 if (!is_optimizing()) { 148 if (!is_optimizing()) {
149 if (FLAG_enable_type_checks && instr->IsAssertAssignable()) { 149 if (FLAG_enable_type_checks && instr->IsAssertAssignable()) {
150 AssertAssignableInstr* assert = instr->AsAssertAssignable(); 150 AssertAssignableInstr* assert = instr->AsAssertAssignable();
151 AddCurrentDescriptor(PcDescriptors::kDeoptBefore, 151 AddCurrentDescriptor(PcDescriptors::kDeopt,
152 assert->deopt_id(), 152 assert->deopt_id(),
153 assert->token_pos()); 153 assert->token_pos());
154 } else if (instr->IsGuardField()) {
155 GuardFieldInstr* guard = instr->AsGuardField();
156 AddCurrentDescriptor(PcDescriptors::kDeopt,
157 guard->deopt_id(),
158 Scanner::kDummyTokenIndex);
159 } else if (instr->CanBeDeoptimizationTarget()) {
160 AddCurrentDescriptor(PcDescriptors::kDeopt,
161 instr->deopt_id(),
162 Scanner::kDummyTokenIndex);
154 } 163 }
155 AllocateRegistersLocally(instr); 164 AllocateRegistersLocally(instr);
156 } 165 }
157 } 166 }
158 167
159 168
160 void FlowGraphCompiler::EmitInstructionEpilogue(Instruction* instr) { 169 void FlowGraphCompiler::EmitInstructionEpilogue(Instruction* instr) {
161 if (is_optimizing()) return; 170 if (is_optimizing()) return;
162 Definition* defn = instr->AsDefinition(); 171 Definition* defn = instr->AsDefinition();
163 if ((defn != NULL) && defn->is_used()) { 172 if ((defn != NULL) && defn->is_used()) {
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
643 652
644 653
645 void ParallelMoveResolver::Exchange(const Address& mem1, const Address& mem2) { 654 void ParallelMoveResolver::Exchange(const Address& mem1, const Address& mem2) {
646 UNIMPLEMENTED(); 655 UNIMPLEMENTED();
647 } 656 }
648 657
649 658
650 } // namespace dart 659 } // namespace dart
651 660
652 #endif // defined TARGET_ARCH_MIPS 661 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698