Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Unified Diff: components/autofill/browser/autofill_manager.cc

Issue 12457033: Implements SendAutocheckoutStatus API calls for stats tracking. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing unit tests Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/autofill_manager.cc
diff --git a/components/autofill/browser/autofill_manager.cc b/components/autofill/browser/autofill_manager.cc
index d2632fc6308f63cad5a94a4cbd83fe8e0a32e355..d9e066986847dddc5441ee7bba842def3c47e034 100644
--- a/components/autofill/browser/autofill_manager.cc
+++ b/components/autofill/browser/autofill_manager.cc
@@ -772,7 +772,8 @@ void AutofillManager::ShowRequestAutocompleteDialog(
const FormData& form,
const GURL& source_url,
autofill::DialogType dialog_type,
- const base::Callback<void(const FormStructure*)>& callback) {
+ const base::Callback<void(const FormStructure*,
+ const std::string&)>& callback) {
manager_delegate_->ShowRequestAutocompleteDialog(
form, source_url, *metric_logger_, dialog_type, callback);
}
@@ -827,7 +828,7 @@ void AutofillManager::OnRequestAutocomplete(
return;
}
- base::Callback<void(const FormStructure*)> callback =
+ base::Callback<void(const FormStructure*, const std::string&)> callback =
base::Bind(&AutofillManager::ReturnAutocompleteData,
weak_ptr_factory_.GetWeakPtr());
ShowRequestAutocompleteDialog(
@@ -850,7 +851,9 @@ void AutofillManager::ReturnAutocompleteResult(
form_data));
}
-void AutofillManager::ReturnAutocompleteData(const FormStructure* result) {
+void AutofillManager::ReturnAutocompleteData(
+ const FormStructure* result,
+ const std::string& unused_transaction_id) {
RequestAutocompleteDialogClosed();
if (!result) {
ReturnAutocompleteResult(WebFormElement::AutocompleteResultErrorCancel,
@@ -884,7 +887,7 @@ void AutofillManager::OnDidEndTextFieldEditing() {
}
void AutofillManager::OnClickFailed(autofill::AutocheckoutStatus status) {
- // TODO(ahutter): Plug into WalletClient.
+ autocheckout_manager_.OnClickFailed(status);
}
void AutofillManager::OnMaybeShowAutocheckoutBubble(
« no previous file with comments | « components/autofill/browser/autofill_manager.h ('k') | components/autofill/browser/autofill_manager_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698