Implements SendAutocheckoutStatus API calls for stats tracking.

components/autofill/renderer/autofill_agent.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/renderer/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop.h"
 #include "base/string_util.h"
@@ skipping 201 matching lines @@
   if (!forms.empty() || !frame->parent()) {
     Send(new AutofillHostMsg_FormsSeen(routing_id(), forms,
                                        forms_seen_timestamp_,
                                        has_more_forms));
   }
 }
 
 void AutofillAgent::DidStartProvisionalLoad(WebFrame* frame) {
   if (!frame->parent()) {
     topmost_frame_ = NULL;
-    WebKit::WebURL provisional_url =
-        frame->provisionalDataSource()->request().url();
-    WebKit::WebURL current_url = frame->dataSource()->request().url();
-    // If the URL of the topmost frame is changing and the current page is part
-    // of an Autocheckout flow, the click was successful as long as the
-    // provisional load is committed.
-    if (provisional_url != current_url && click_timer_.IsRunning()) {

[Ilya Sherman, 2013/03/27 22:27:21]

Hmm, why is this check no longer relevant?

[Ilya Sherman, 2013/03/27 22:35:09]

Per IM discussion, this is now handled on the browser side, so it doesn't need
to be on the renderer.

+    if (click_timer_.IsRunning()) {
       click_timer_.Stop();
       autocheckout_click_in_progress_ = true;
     }
   }
 }
 
 void AutofillAgent::DidFailProvisionalLoad(WebFrame* frame,
                                            const WebKit::WebURLError& error) {
-  if (autocheckout_click_in_progress_) {
+  if (!frame->parent() && autocheckout_click_in_progress_) {

[Ilya Sherman, 2013/03/27 22:27:21]

How do you know that all clicks in Autocheckout will always navigate the top
frame?  Though I suppose that if this isn't a problem for now, we can just hold
off on thinking about it until it comes up.

[ahutter, 2013/03/27 22:41:45]

I guess I don't but so far they have.  If/when we need to worry about changes by
frame this will all become more complicated.

     autocheckout_click_in_progress_ = false;
     ClickFailed();
   }
 }
 
 void AutofillAgent::DidCommitProvisionalLoad(WebFrame* frame,
                                              bool is_new_navigation) {
-  autocheckout_click_in_progress_ = false;
   in_flight_request_form_.reset();
+  if (!frame->parent())
+    autocheckout_click_in_progress_ = false;
 }
 
 void AutofillAgent::FrameDetached(WebFrame* frame) {
   form_cache_.ResetFrame(*frame);
   if (!frame->parent()) {
     // |frame| is about to be destroyed so we need to clear |top_most_frame_|.
     topmost_frame_ = NULL;
     click_timer_.Stop();
   }
 }
@@ skipping 490 matching lines @@
 
 void AutofillAgent::OnFillFormsAndClick(
     const std::vector<FormData>& forms,
     const WebElementDescriptor& click_element_descriptor) {
   DCHECK_EQ(forms.size(), form_elements_.size());
 
   // Fill the form.
   for (size_t i = 0; i < forms.size(); ++i)
     FillFormIncludingNonFocusableElements(forms[i], form_elements_[i]);
 
+  // Exit early if there is nothing to click.
+  if (click_element_descriptor.retrieval_method == WebElementDescriptor::NONE)
+    return;
+
   // It's possible that clicking the element to proceed in an Autocheckout
   // flow will not actually proceed to the next step in the flow, e.g. there
   // is a new required field that Autocheckout does not know how to fill.  In
   // order to capture this case and present the user with an error a timer is
   // set that informs the browser of the error. |click_timer_| has to be started
   // before clicking so it can start before DidStartProvisionalLoad started.
   click_timer_.Start(FROM_HERE,
                      base::TimeDelta::FromSeconds(kAutocheckoutClickTimeout),
                      this,
                      &AutofillAgent::ClickFailed);
@@ skipping 154 matching lines @@
     web_view->hidePopups();
 
   HideHostAutofillUi();
 }
 
 void AutofillAgent::HideHostAutofillUi() {
   Send(new AutofillHostMsg_HideAutofillUi(routing_id()));
 }
 
 }  // namespace autofill