Implement a policy to auto-login a public account.

Implement a policy to auto-login a public account.

Un-revert 12218078, and check if the device local account policy
is already set before spinning a run loop in 
ExistingUserControllerPublicSessionTest#SetUpOnMainThread.

BUG=152933
TBR=satorux


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189225

[dconnelly, 2013-03-18 21:42:31]

I manually ran the linux_chromeos try bot and this appears to have fixed the
flakiness.  I'll run it a few more times manually.

http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds...

[Mattias Nissler (ping if slow), 2013-03-19 04:56:45]

Where's the change exactly? Do I have to review the entire CL again? ;)

[dconnelly1, 2013-03-19 05:06:14]

Whoops, sorry.  It's lines 462-468 of
https://codereview.chromium.org/12457029/diff/1/chrome/browser/chromeos/login...

On Mon, Mar 18, 2013 at 9:56 PM,  <mnissler@chromium.org> wrote:
> Where's the change exactly? Do I have to review the entire CL again? ;)
>
> https://codereview.chromium.org/12457029/

[Mattias Nissler (ping if slow), 2013-03-19 05:24:41]

LGTM then

https://codereview.chromium.org/12457029/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
(right):

https://codereview.chromium.org/12457029/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:466:
DCHECK(store);
Remove this DCHECK, we'll crash below anyways if the check fails.

[bartfab (slow), 2013-03-19 10:26:36]

lgtm

[Nikita (slow), 2013-03-19 11:27:46]

On 2013/03/19 05:06:14, dconnelly_google.com wrote:
> Whoops, sorry.  It's lines 462-468 of
>
https://codereview.chromium.org/12457029/diff/1/chrome/browser/chromeos/login...
> 
> On Mon, Mar 18, 2013 at 9:56 PM,  <mailto:mnissler@chromium.org> wrote:
> > Where's the change exactly? Do I have to review the entire CL again? ;)
> >
> > https://codereview.chromium.org/12457029/

Another option is to reuse previous issue so that patch is clearly seen.

lgtm

[dconnelly, 2013-03-19 17:40:08]

https://codereview.chromium.org/12457029/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
(right):

https://codereview.chromium.org/12457029/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:466:
DCHECK(store);
On 2013/03/19 05:24:41, Mattias Nissler wrote:
> Remove this DCHECK, we'll crash below anyways if the check fails.

Done.

[dconnelly, 2013-03-19 18:11:06]

hi satorux---I need your OWNER approval again for this stuff in chromeos/dbus. 
The original CL got reverted for a flaky test.  thanks!

[dconnelly, 2013-03-19 23:59:32]

hi satorux, since none of the dbus/ stuff changed since the last time you
reviewed this I'm going to add you to the TBR= line.  please let me know if you
see anything that I should fix and I'll work on it.

[commit-bot: I haz the power, 2013-03-20 01:03:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dconnelly@chromium.org/12457029/22001

[commit-bot: I haz the power, 2013-03-20 02:30:26]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-03-20 05:18:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dconnelly@chromium.org/12457029/22001

[commit-bot: I haz the power, 2013-03-20 09:21:38]

Change committed as 189225