crypto/third_party/curve25519-donna/README.chromium - Issue 12457004: Curve25519-donna changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: crypto/third_party/curve25519-donna/README.chromium

Issue 12457004: Curve25519-donna changes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 Name: curve25519-donna

	2 URL: https://github.com/agl/curve25519-donna

	3 License: MPL 1.1/GPL 2.0/LGPL 2.1
	wtc 2013/03/06 00:55:58 The license is the BSD license. The license is the BSD license. ramant (doing other things) 2013/03/06 19:01:05 Done. Show quoted text On 2013/03/06 00:55:58, wtc wrote: > > The license is the BSD license. Done.
	4

	5 We extracted the curve25519-donna.c source file, and tweaked it for Chrome's

	6 source tree. curve25519-donna.c is renamed curve25519-donna.cc so that it can

	7 include Chrome's C++ header "base/basictypes.h". Used basic types from

	8 "basictypes.h" instead of "stdint.h"
	wtc 2013/03/06 00:55:58 I highly recommend we keep curve25519-donna.c as a I highly recommend we keep curve25519-donna.c as a C file and not patch it. Today, only compilers that don't have <stdint.h> are older versions of Visual C++. Chromium requires Visual C++ 2010 or later, and Visual C++ 2010 has <stdint.h>. So we should be able to just use <stdint.h>. Our patches to third-party code need to be maintained. So it is best if we don't need to patch. This includes not adding the curve25519-donna.h header file. ramant (doing other things) 2013/03/06 19:01:05 Done. Show quoted text On 2013/03/06 00:55:58, wtc wrote: > > I highly recommend we keep curve25519-donna.c as a C file > and not patch it. > > Today, only compilers that don't have <stdint.h> are older > versions of Visual C++. Chromium requires Visual C++ 2010 > or later, and Visual C++ 2010 has <stdint.h>. So we should > be able to just use <stdint.h>. > > Our patches to third-party code need to be maintained. > So it is best if we don't need to patch. This includes > not adding the curve25519-donna.h header file. Done.
OLD	NEW

« crypto/curve25519.cc ('K') | « crypto/third_party/curve25519-donna/README ('k') | crypto/third_party/curve25519-donna/curve25519-donna.h » ('j') | no next file with comments »